Optimize loss calculation with in-place gradients calculation ~40% memory save#185
Merged
sleepcoo merged 3 commits intosgl-project:mainfrom Aug 27, 2025
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The loss calculation on TTT steps of logits are taking up huge chunk of memory. According to the memory profiling, it is due to the intermediate tensors and gradients created during backward torch autograd.
??:0:torch::autograd::generated::EmbeddingBackward0::apply(std::vector<at::Tensor, std::allocator<at::Tensor> >&&)We would like to save the gradients into the logits instead of creating a separate tensor.
Modifications
Added a triton implementation of log softmax calculation with in-place mod of input logits.
Related Issues
#112
Accuracy Test
Unit test added
Benchmark & Profiling
Also 50% faster
Checklist