support qwen3 coder draft model, add opc dataset process#73
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @yizhang2077, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the Qwen3 Coder draft model, enabling its offline training capabilities, particularly with the EAGLE3 speculative decoding algorithm. It also standardizes benchmark configurations by increasing the maximum output token length for several evaluation scripts and integrates a new dataset processing pipeline for the OPC dataset, facilitating training data preparation.
Highlights
- Qwen3 Coder Draft Model Support: Added necessary configurations and an example script to support offline training of the Qwen3 Coder model with the EAGLE3 speculative decoding algorithm.
- Benchmark Consistency: Standardized the
max_new_tokensparameter to 2048 acrossrun_gsm8k.py,run_humaneval.py, andrun_math500.pybenchmarks, ensuring longer and more consistent output generation during evaluations. - OPC Dataset Integration: Introduced new functionality in
prepare_data.pyto process theOpenCoder-LLM/opc-sft-stage1dataset, making it available for training purposes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for the Qwen3 Coder draft model and integrates the opc dataset for offline training. The changes also standardize the maximum output token length in several benchmark scripts. My review includes suggestions for scripts/prepare_data.py to improve code style and update an error message for better maintainability and correctness.
| return ds | ||
|
|
||
|
|
||
| import hashlib |
There was a problem hiding this comment.
| proc_fn = process_opc_sft_stage1 | ||
| else: | ||
| raise ValueError( | ||
| f"This script only supports ultrachat_200k and sharegpt datasets for demo purpose, if you wish to use other datasets, please modify this script." |
There was a problem hiding this comment.
This error message is now outdated as the script supports the opc dataset. Please update the message to include opc in the list of supported datasets to avoid confusion.
raise ValueError(
f"This script only supports ultrachat, sharegpt, and opc datasets for demo purpose, if you wish to use other datasets, please modify this script."
)|
great job!!! |
f0f3342 to
03550c4
Compare
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
能否分享下你的qwen3-Coder草稿模型 |
Uh oh!
There was an error while loading. Please reload this page.