Skip to content

fix(doc): document -1 sentinel in ForwardInput.write_tuple#106

Open
MisakaVan wants to merge 1 commit intosgl-project:mainfrom
MisakaVan:fix-doc
Open

fix(doc): document -1 sentinel in ForwardInput.write_tuple#106
MisakaVan wants to merge 1 commit intosgl-project:mainfrom
MisakaVan:fix-doc

Conversation

@MisakaVan
Copy link
Contributor

Summary

  • The inline comment on ForwardInput.write_tuple in scheduler.py documented the sentinel value as 0, but _make_write_tuple actually uses -1 for finished requests that cannot decode.

Reference

_make_write_tuple function:

    write_list = [(req.device_len if req.can_decode else -1) for req in batch.reqs]

The inline comment incorrectly documented the sentinel value as "or 0".
The actual code uses -1 for requests that cannot decode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant