-
Notifications
You must be signed in to change notification settings - Fork 74
add soft fp8 feat(matmul and grouped matmul ops) #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add soft fp8 feat(matmul and grouped matmul ops) #268
Conversation
Summary of ChangesHello @LinyuanLi0046, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's capability by integrating software-driven support for 8-bit floating-point (FP8) operations. It specifically targets matrix multiplication (MatMul) and grouped matrix multiplication, incorporating a crucial step of dequantizing FP8 weights to BFloat16 (BF16) during the computation. This approach aims to balance performance efficiency with numerical accuracy, particularly benefiting large language models and has been verified with the Qwen3-MoE-30B-A3B-FP8 model. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Soft FP8 support for MatMul and Grouped MatMul operations, including weight dequantization from FP8 to BF16. The changes involve adding new host-side and kernel-side C++ files, updating CMakeLists.txt to include these new components, and registering the new operations in pytorch_extensions.cpp and sgl_kenel_npu_ops.h. The implementation appears to be comprehensive, covering the necessary data type conversions, memory management, and kernel launching mechanisms for the AscendC platform. The introduction of catlass_op_utils.cpp centralizes utility functions for data type conversions and tensor creation, which is a good practice for maintainability. The kernel implementations for both MatMul and Grouped MatMul leverage custom block MMAD policies and tile operations for efficient FP8 dequantization and computation. Overall, the changes are well-structured and align with the stated objective of adding Soft FP8 support.
csrc/catlass/utils/gemm/block/block_mmad_pingpong_with_prologue_fp8_w8a16.hpp
Show resolved
Hide resolved
…com/LinyuanLi0046/sgl-kernel-npu into feat/soft-fp8-matmul&grouped-matmul
…com/LinyuanLi0046/sgl-kernel-npu into feat/soft-fp8-matmul&grouped-matmul
…com/LinyuanLi0046/sgl-kernel-npu into feat/soft-fp8-matmul&grouped-matmul
This MR introduces Soft FP8 support by adding software-based FP8 computation paths with weight dequantization (FP8 → BF16).