Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enabling the Qwen3 30B model test within the CI pipeline and refining the Qwen3 Mixture of Experts (MoE) model's forward pass. The changes ensure that expert parallel all-reduce operations are correctly applied under specific conditions, which is crucial for the model's distributed execution and accuracy. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
/tag-run-ci-label |
There was a problem hiding this comment.
Code Review
This pull request enables a test for qwen3 and includes a fix for expert parallelism in the MoE layer. The fix adds an all-reduce operation for expert parallelism. However, the condition under which this all-reduce is performed seems incorrect, as it is tied to the fusion of the tensor parallelism all-reduce, which can lead to incorrect results when fusion is enabled. I've suggested a correction to ensure the expert parallelism all-reduce is always performed when needed.
|
/tag-and-rerun-ci |
|
/rerun-stage stage-c-test-4-gpu-h100 |
|
✅ Triggered |
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci