Skip to content

Enable the qwen3 test#21195

Merged
Fridge003 merged 1 commit intosgl-project:mainfrom
Shunkangz:enble_qwen3_test
Mar 24, 2026
Merged

Enable the qwen3 test#21195
Fridge003 merged 1 commit intosgl-project:mainfrom
Shunkangz:enble_qwen3_test

Conversation

@Shunkangz
Copy link
Contributor

@Shunkangz Shunkangz commented Mar 23, 2026

Motivation

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enabling the Qwen3 30B model test within the CI pipeline and refining the Qwen3 Mixture of Experts (MoE) model's forward pass. The changes ensure that expert parallel all-reduce operations are correctly applied under specific conditions, which is crucial for the model's distributed execution and accuracy.

Highlights

  • Qwen3 MoE Model Update: Introduced a conditional moe_expert_parallel_all_reduce operation within the forward_normal function of the Qwen3 MoE model, specifically when expert parallelism is enabled and all-reduce fusion is not active. This ensures proper handling of expert outputs in distributed environments.
  • Qwen3 Test Re-enablement: The test_qwen3_30b.py test case, which was previously disabled, has been re-enabled by removing the disabled flag from its register_cuda_ci decorator. This allows the Qwen3 30B model test to run as part of the CI pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Shunkangz
Copy link
Contributor Author

/tag-run-ci-label

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables a test for qwen3 and includes a fix for expert parallelism in the MoE layer. The fix adds an all-reduce operation for expert parallelism. However, the condition under which this all-reduce is performed seems incorrect, as it is tied to the fusion of the tensor parallelism all-reduce, which can lead to incorrect results when fusion is enabled. I've suggested a correction to ensure the expert parallelism all-reduce is always performed when needed.

@Fridge003
Copy link
Collaborator

/tag-and-rerun-ci

@Fridge003
Copy link
Collaborator

/rerun-stage stage-c-test-4-gpu-h100

@github-actions
Copy link
Contributor

✅ Triggered stage-c-test-4-gpu-h100 to run independently (skipping dependencies).

@github-actions
Copy link
Contributor

🔗 View workflow run

@Fridge003
Copy link
Collaborator

@Fridge003 Fridge003 merged commit dac1481 into sgl-project:main Mar 24, 2026
239 of 284 checks passed
adityavaid pushed a commit to adityavaid/sglang that referenced this pull request Mar 24, 2026
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
adityavaid pushed a commit to adityavaid/sglang that referenced this pull request Mar 24, 2026
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
0-693 pushed a commit to 0-693/sglang that referenced this pull request Mar 25, 2026
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
johnnycxm pushed a commit to johnnycxm/sglang that referenced this pull request Mar 25, 2026
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
johnnycxm pushed a commit to johnnycxm/sglang that referenced this pull request Mar 25, 2026
Co-authored-by: Shunkang <182541032+Shunkangz@users.noreply.github.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants