Skip to content

Allow overriding the autocomplete attribute on password_field #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow overriding the autocomplete attribute on password_field #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3be59f8
Check autocomplete attr to 'off' in form_builder specs
Quentinchampenois May 17, 2022
dd17d55
Allow override autocomplete attr on password_field
Quentinchampenois May 17, 2022
ed57748
Allow override autocomplete attr on time_zone_select
Quentinchampenois May 17, 2022
2aef942
Allow override autocomplete attr on date_select
Quentinchampenois May 17, 2022
540e44f
Allow override autocomplete attr on datetime_select
Quentinchampenois May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/foundation_rails_helper/form_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,27 +50,30 @@ def radio_button(attribute, tag_value, options = {})

def password_field(attribute, options = {})
field attribute, options do |opts|
super(attribute, opts.merge(autocomplete: :off))
opts[:autocomplete] ||= :off
super(attribute, opts)
end
end

def datetime_select(attribute, options = {}, html_options = {})
field attribute, options, html_options do |html_opts|
super(attribute, options, html_opts.merge(autocomplete: :off))
html_options[:autocomplete] ||= :off
super(attribute, options, html_opts)
end
end

def date_select(attribute, options = {}, html_options = {})
field attribute, options, html_options do |html_opts|
super(attribute, options, html_opts.merge(autocomplete: :off))
html_options[:autocomplete] ||= :off
super(attribute, options, html_opts)
end
end

# rubocop:disable LineLength
def time_zone_select(attribute, priorities = nil, options = {}, html_options = {})
field attribute, options, html_options do |html_opts|
super(attribute, priorities, options,
html_opts.merge(autocomplete: :off))
html_options[:autocomplete] ||= :off
super(attribute, priorities, options, html_opts)
end
end
# rubocop:enable LineLength
Expand Down
23 changes: 19 additions & 4 deletions spec/foundation_rails_helper/form_builder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,26 @@
expect(node)
.to have_css('label[for="author_password"]', text: "Password")
expect(node)
.to have_css('input[type="password"][name="author[password]"]')
.to have_css('input[type="password"][name="author[password]"][autocomplete="off"]')
expect(node.find_field("author_password").value).to be_nil
end
end

context "when autocomplete attribute is defined in password_field input" do
let(:options) { { autocomplete: "new-password" } }

it "generates password_field input with autocomplete attribute" do
form_for(@author) do |builder|
node = Capybara.string builder.password_field(:password, options)
expect(node)
.to have_css('label[for="author_password"]', text: "Password")
expect(node)
.to have_css('input[type="password"][name="author[password]"][autocomplete="new-password"]')
expect(node.find_field("author_password").value).to be_nil
end
end
end

it "should generate email_field input" do
form_for(@author) do |builder|
node = Capybara.string builder.email_field(:email)
Expand Down Expand Up @@ -468,7 +483,7 @@
expect(node)
.to have_css('label[for="author_birthdate"]', text: "Birthdate")
%w(1 2 3).each do |i|
expect(node).to have_css("select[name='author[birthdate(#{i}i)]']")
expect(node).to have_css("select[name='author[birthdate(#{i}i)]'][autocomplete='off']")
end
expect(node)
.to have_css("#{select}1i #{option}[value=\"1969\"]")
Expand Down Expand Up @@ -519,7 +534,7 @@
expect(node)
.to have_css('label[for="author_birthdate"]', text: "Birthdate")
%w(1 2 3 4 5).each do |i|
expect(node).to have_css("select[name='author[birthdate(#{i}i)]']")
expect(node).to have_css("select[name='author[birthdate(#{i}i)]'][autocomplete='off']")
end
expect(node).to have_css("#{select}1i #{option}[value=\"1969\"]")
expect(node).to have_css("#{select}2i #{option}[value=\"6\"]")
Expand Down Expand Up @@ -559,7 +574,7 @@
)
expect(node)
.to have_css('label[for="author_time_zone"]', text: "Time zone")
expect(node).to have_css('select[name="author[time_zone]"]')
expect(node).to have_css('select[name="author[time_zone]"][autocomplete="off"]')
expect(node)
.to have_css('select[name="author[time_zone]"] option[value="Perth"]',
text: "(GMT+08:00) Perth")
Expand Down