Harden type/data model consistency for chatrooms and realtime events#4
Open
ocrichardbot wants to merge 1 commit intosgzsh269:mainfrom
Open
Harden type/data model consistency for chatrooms and realtime events#4ocrichardbot wants to merge 1 commit intosgzsh269:mainfrom
ocrichardbot wants to merge 1 commit intosgzsh269:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tackles the type-consistency hardening gap by aligning DB schema types and event payload contracts across API + realtime layers.
Changes
chatrooms.is_privatefrom text ("0"/"1") to boolean in Drizzle schemachatroom_invites.max_usesfrom text to integer in Drizzle schema0001_type_hardening.sqlto safely convert existing valueszodrequest validation forPOST /api/chatroomsisPrivatedirectlymaxUsesdirectlyupdatedBy.idandmember.idWhy
Notes
bunis not installed on the host (bun: command not found).