Make LSPSDateTime Copy rather than explicitely _clone_ing

Author: martinsaposnic

lightning-liquidity/src/lsps0/ser.rs

@@ -218,7 +218,7 @@ impl wire::Type for RawLSPSMessage {
 pub struct LSPSRequestId(pub String);
 
 /// An object representing datetimes as described in bLIP-50 / LSPS0.
-#[derive(Clone, Debug, PartialEq, Eq, Hash, Deserialize, Serialize)]
+#[derive(Clone, Debug, Copy, PartialEq, Eq, Hash, Deserialize, Serialize)]
 #[serde(transparent)]
 pub struct LSPSDateTime(pub chrono::DateTime<chrono::Utc>);
 

lightning-liquidity/src/lsps1/service.rs

@@ -266,7 +266,7 @@ where
 						let order_id = self.generate_order_id();
 						let channel = OutboundCRChannel::new(
 							params.order.clone(),
-							created_at.clone(),
+							created_at,
 							order_id.clone(),
 							payment.clone(),
 						);

lightning-liquidity/src/lsps2/msgs.rs

@@ -72,7 +72,7 @@ impl LSPS2RawOpeningFeeParams {
 		LSPS2OpeningFeeParams {
 			min_fee_msat: self.min_fee_msat,
 			proportional: self.proportional,
-			valid_until: self.valid_until.clone(),
+			valid_until: self.valid_until,
 			min_lifetime: self.min_lifetime,
 			max_client_to_self_delay: self.max_client_to_self_delay,
 			min_payment_size_msat: self.min_payment_size_msat,
@@ -235,7 +235,7 @@ mod tests {
 		let raw = LSPS2RawOpeningFeeParams {
 			min_fee_msat,
 			proportional,
-			valid_until: valid_until.clone().into(),
+			valid_until: valid_until.into(),
 			min_lifetime,
 			max_client_to_self_delay,
 			min_payment_size_msat,

lightning-liquidity/src/lsps5/service.rs

@@ -185,7 +185,7 @@ where
 			Entry::Occupied(mut entry) => {
 				no_change = entry.get().url == params.webhook;
 				let (last_used, last_notification_sent) = if no_change {
-					(entry.get().last_used.clone(), entry.get().last_notification_sent.clone())
+					(entry.get().last_used, entry.get().last_notification_sent.clone())
 				} else {
 					(now, new_hash_map())
 				};
@@ -438,8 +438,8 @@ where
 		}
 
 		for (app_name, webhook) in client_webhooks.iter_mut() {
-			webhook.last_notification_sent.insert(notification.method.clone(), now.clone());
-			webhook.last_used = now.clone();
+			webhook.last_notification_sent.insert(notification.method.clone(), now);
+			webhook.last_used = now;
 			self.send_notification(
 				client_id,
 				app_name.clone(),