Open
Conversation
shadaj
force-pushed
the
main
branch
3 times, most recently
from
7b5ecd9 to
72a3416
Compare
threeseed
force-pushed
the
scalafix
branch
5 times, most recently
from
66ee7b7 to
a8965f2
Compare
threeseed
force-pushed
the
scalafix
branch
12 times, most recently
from
efc7106 to
82312e2
Compare
threeseed
force-pushed
the
scalafix
branch
3 times, most recently
from
268f5a2 to
e121559
Compare
threeseed
force-pushed
the
scalafix
branch
8 times, most recently
from
b9dc850 to
4397ac0
Compare
threeseed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #717
a) Adds a new SBT Plugin which uses Scalameta to expand files with the @react annotation into target/src_managed.
b) Temporarily disables Scalafix as it fails due to SemanticDB not working with src_managed.
c) Tests against multiple JVM versions i.e. 17 as default and latest.
d) We hit this issue which is new to Scala3 and so had to rename apply(Props) -> applyProps(Props) within Slinky.