fix(components): prevent sidebar overflow with inset variant #7950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shadcn-ui#7947 - Replace hardcoded h-svh with conditional h-full for inset variant - Fixes 16px overflow caused by SidebarProvider padding not being respected - Applied to both default and new-york variants
|
@teejcoder is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes sidebar overflow issue when using
variant="inset".Closes #7947
Problem
The sidebar spacer element used
h-svhwhich doesn't account for theSidebarProvider'sp-2padding (8px), causing 16px page overflow.Solution
h-fullfor inset variant to respect parent container paddingTesting
pnpm build:registryType of change