fix(production web): 🎨 🛠️ remove duplicate Toaster causing broken theme on production #7967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grimza99 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
grimza99
changed the title
grimza99
changed the title
|
@shadcn Looks like a minimal change to me, but since it fixes a production-facing bug, I think it’s worth merging quickly. |
grimza99
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👩💻Problem
On production,
ui.shadcn.com/docs/components/sidebar#sidebargroupactiontoast messages rendered in the wrong position and without theme styling.Root cause: a duplicate was rendered — once globally (app/layout.tsx) and once locally (sidebar-group-action.tsx).
The local one bypassed the global layout/theme, leading to inconsistent behavior.
✅Solution
Removed the local from sidebar-group-action.tsx
Kept only the global defined in layout
Updated toast(...) calls to pass position and className via options, so customization is still possible per page
📷Preview
After applying the fix, the toast now appears as expected, with correct positioning and theme styling:
Dark theme
Light theme
issues
#7801