fix(command): improve macOS VoiceOver arrow key navigation (#8853) #8876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves accessibility of the Command component when macOS VoiceOver is enabled.
When VoiceOver is active, arrow keys are handled by the screen reader.
However, the current implementation in
cmdkcallspreventDefault()on arrow keys,which prevents VoiceOver from moving focus between items.
This change allows arrow key events to pass through on macOS, enabling proper screen reader navigation.
What was changed
onKeyDownhandler to Command wrappernavigator.platform.includes("Mac"))ArrowDown/ArrowUpevents without being interceptedReproduction (before fix)
/docs/components/command)→ Focus does not move
After fix
Why this is safe
Fixes: #8853