fix(ui): fix calendar layout collapse in safari using grid#9612
Open
yanhanruan wants to merge 2 commits intoshadcn-ui:mainfrom
Open
fix(ui): fix calendar layout collapse in safari using grid#9612yanhanruan wants to merge 2 commits intoshadcn-ui:mainfrom
yanhanruan wants to merge 2 commits intoshadcn-ui:mainfrom
Conversation
Replaces flex layout with css grid for calendar weeks and days to ensure consistent width handling in WebKit browsers.
Contributor
|
@yanhanruan is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a layout issue in Safari (WebKit) where the Calendar component would collapse or behave unexpectedly when set to
w-fullinside a constrained container.The issue was caused by Safari's handling of
flexlayouts withintablestructures. This fix replaces theflexlayout for weeks and weekdays withgrid, and adjusts theCalendarDayButtonto fully fill the grid cells, ensuring consistent rendering across Chrome, Firefox, and Safari.Fixes
Closes #9468
Visual Evidence
Changes
tableclass toblockto prevent layout collapse.weekdaysandweekrows to usegrid grid-cols-7.CalendarDayButtontoh-full w-fullto fix sizing inconsistencies in grid cells.