Add support for late capability checks#10046
Draft
skiminki-nv wants to merge 7 commits intoshader-slang:masterfrom
Draft
Add support for late capability checks#10046skiminki-nv wants to merge 7 commits intoshader-slang:masterfrom
skiminki-nv wants to merge 7 commits intoshader-slang:masterfrom
Conversation
Add new IR instruction IRLateRequireCapability, which can be used to perform capability requirement checks after linking, specialization, and all IR-level dead code elimination has been done. Issue shader-slang#9210
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
|
This PR modifies IR instruction definition files. Please review if you need to update the following constants in
These version numbers help ensure compatibility between different versions of compiled modules. |
This pass is done before dead code elimination has had a chance to remove any branches.
Remove redundant atoms from the definition. Note that texture_sm_4_1 already provides the basic shadow lod functionality. GL_EXT_texture_shadow_lod adds support for 2d shadow array, shadow cube, and shadow cube array. Realistically, sm_4_1 is present always when GL_EXT_texture_shadow_lod is present.
Specify glsl_460 + GL_EXT_texture_shadow_lod for the glsl target. This silences a warning and makes the test pass.
Contributor
Author
|
/format |
Contributor
|
🌈 Formatted, please merge the changes from this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new IR instruction IRLateRequireCapability, which can be used to perform capability requirement checks after linking, specialization, and all IR-level dead code elimination has been done.
Issue #9210