Add regression test for zero-size array ICE (#10069)#10070
Open
rkoivunen-sw wants to merge 1 commit intoshader-slang:masterfrom
Open
Add regression test for zero-size array ICE (#10069)#10070rkoivunen-sw wants to merge 1 commit intoshader-slang:masterfrom
rkoivunen-sw wants to merge 1 commit intoshader-slang:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA regression test file is added to reproduce an internal compiler error (ICE 99999) when a zero-size array is nested within a struct definition in a compute shader, targeting SPIR-V compilation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression test for #10069
The test uses filecheck to verify error 99999 is emitted. Once the bug is fixed (either by rejecting zero-size arrays with a diagnostic or by handling them correctly), the test should be updated.
slangc tests/bugs/zero-size-array-nested-struct.slang -target spirv -entry computeMain -stage compute -o /dev/null # Currently: error 99999