Disable unnecessary components in check-cmdline-ref CI build#10099
Disable unnecessary components in check-cmdline-ref CI build#10099aidanfnv wants to merge 1 commit intoshader-slang:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThe GitHub Actions workflow for the command-line reference check was modified to build Slang with a direct cmake target invocation instead of a preset-based workflow build, while adding multiple cmake configuration flags to customize the build. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR optimizes the check-cmdline-ref CI workflow by disabling unnecessary components during the CMake build configuration and building only the slangc target instead of the entire project. The workflow only needs to run slangc -help-style markdown -h to generate command-line reference documentation, so most Slang components (GFX, slangd, slangrt, slangi, etc.) are not required. This optimization reduces build time from 18+ minutes to approximately 10 minutes.
Changes:
- Added CMake flags to disable nine unnecessary components (embedded core module, slangrt, slangi, glslang, replayer, DXIL, RHI, prebuilt binaries, and release debug info)
- Changed build command from
cmake --workflow --preset releasetocmake --build --preset release --target slangcto build only the slangc binary
The
check-cmdline-refworkflow builds far more than it needs to. It only runsslangc -help-style markdown -h, which does not require most of the components that are enabled by default, most notably the embedded core module.This disables many if not all unnecessary components at configure time and builds only
--target slangcto significantly speed up the workflow (~10 minutes instead of 18+ minutes).