-
Notifications
You must be signed in to change notification settings - Fork 429
Add nightly CI for Sascha Willems Vulkan Slang shaders #10474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jvepsalainen-nv
merged 11 commits into
shader-slang:master
from
jvepsalainen-nv:ci-add-sascha-willems
Mar 11, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ecc279a
Add nightly CI for Sascha Willems Vulkan Slang shaders
jvepsalainen-nv e8a9209
Update known failure comment with issue #10473
jvepsalainen-nv 38d2efe
Address review feedback: improve error handling in script
jvepsalainen-nv a81db87
Merge branch 'master' into ci-add-sascha-willems
jvepsalainen-nv 0290792
format code
slangbot 5f22413
Merge pull request #10 from slangbot/format-10474-ci-add-sascha-willems
jvepsalainen-nv 8821e0b
Merge branch 'master' into ci-add-sascha-willems
jvepsalainen-nv 186778a
Address review: add cd guard, remove duplicate env var
jvepsalainen-nv 2968052
Disable Slack notifications until follow-up PR
jvepsalainen-nv 984bb6d
Merge branch 'master' into ci-add-sascha-willems
jvepsalainen-nv 469b1aa
Reuse merge queue build artifacts instead of building from source
jvepsalainen-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
131 changes: 131 additions & 0 deletions
131
.github/workflows/compile-sascha-willems-shaders-nightly.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| name: Sascha Willems Vulkan Shaders (Nightly) | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| # Run daily at 4 AM UTC (after RTX Remix and coverage runs) | ||
| - cron: "0 4 * * *" | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
| actions: read | ||
|
|
||
| jobs: | ||
| sascha-willems-shader-test: | ||
| runs-on: windows-2022 | ||
| timeout-minutes: 30 | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| steps: | ||
| - name: Checkout Slang repository | ||
| uses: actions/checkout@v4 | ||
jvepsalainen-nv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: Add bash to PATH | ||
| shell: pwsh | ||
| run: | | ||
| Add-Content -Path $env:GITHUB_PATH -Value "C:\\Program Files\\Git\\bin" | ||
| - name: Download Slang build from latest successful merge queue | ||
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| echo "Finding latest successful merge queue CI run..." | ||
| RUN_INFO=$(gh run list --repo ${{ github.repository }} \ | ||
| --workflow ci.yml --status success --event merge_group --limit 1 \ | ||
| --json databaseId,headSha,createdAt) | ||
| RUN_ID=$(echo "$RUN_INFO" | jq -r '.[0].databaseId') | ||
| COMMIT=$(echo "$RUN_INFO" | jq -r '.[0].headSha') | ||
| CREATED=$(echo "$RUN_INFO" | jq -r '.[0].createdAt') | ||
| if [ -z "$RUN_ID" ] || [ "$RUN_ID" = "null" ]; then | ||
| echo "No successful CI run found" | ||
| exit 1 | ||
| fi | ||
| echo "Downloading from CI run $RUN_ID (commit: ${COMMIT:0:12}, created: $CREATED)" | ||
| gh run download "$RUN_ID" --repo ${{ github.repository }} \ | ||
| --name slang-build-windows-x86_64-cl-release \ | ||
| --dir slang-build/ | ||
| slangcPath=$(find slang-build -name "slangc.exe" -type f | head -1) | ||
| if [ -z "$slangcPath" ]; then | ||
| echo "slangc.exe not found in artifact" | ||
| find slang-build -type f | head -30 | ||
| exit 1 | ||
| fi | ||
| echo "Found slangc at: $slangcPath" | ||
| "$slangcPath" -version | ||
| - name: Clone SaschaWillems/Vulkan repository (sparse checkout) | ||
| run: | | ||
| echo "Cloning SaschaWillems/Vulkan (shaders/slang only)..." | ||
| git clone --depth 1 --filter=blob:none --sparse \ | ||
| https://github.com/SaschaWillems/Vulkan.git SaschaWillems-Vulkan | ||
| cd SaschaWillems-Vulkan || exit 1 | ||
| git sparse-checkout set shaders/slang | ||
| commit=$(git rev-parse HEAD) | ||
| echo "Using SaschaWillems/Vulkan commit: $commit" | ||
jvepsalainen-nv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| slangCount=$(find shaders/slang -name "*.slang" | wc -l | xargs) | ||
| echo "Found $slangCount .slang shader files" | ||
| - name: Compile Slang shaders | ||
| run: | | ||
| echo "Compiling Sascha Willems Vulkan Slang shaders..." | ||
| slangcPath=$(find slang-build -name "slangc.exe" -type f | head -1) | ||
| ./extras/compile-sascha-willems-shaders.sh \ | ||
| --slangc "$slangcPath" \ | ||
| --repo SaschaWillems-Vulkan \ | ||
| --spirv-val | ||
| - name: Report results | ||
| if: always() | ||
| run: | | ||
| echo "" | ||
| echo "================================================" | ||
| if [ "$BUILD_RESULT" = "success" ]; then | ||
| echo "Sascha Willems shader test PASSED" | ||
| echo "Slang compiler changes are compatible with Sascha Willems Vulkan shaders" | ||
| else | ||
| echo "Sascha Willems shader test FAILED" | ||
| echo "Slang compiler changes may have broken shader compilation" | ||
| echo "Review build logs for details" | ||
| fi | ||
| echo "================================================" | ||
| env: | ||
| BUILD_RESULT: ${{ job.status }} | ||
|
|
||
| # Slack notifications disabled - will be enabled in a follow-up PR | ||
| - name: Success notification | ||
| id: slack-notify-success | ||
| if: false # ${{ github.event_name == 'schedule' && success() }} | ||
| uses: slackapi/slack-github-action@v1.26.0 | ||
| with: | ||
| payload: | | ||
| { | ||
| "Sascha-Willems-Nightly": ":green-check-mark: Sascha Willems shader nightly status: ${{ job.status }}" | ||
| } | ||
jvepsalainen-nv marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
|
|
||
| - name: Failure notification | ||
| id: slack-notify-failure | ||
| if: false # ${{ github.event_name == 'schedule' && !success() }} | ||
| uses: slackapi/slack-github-action@v1.26.0 | ||
| with: | ||
| payload: | | ||
| { | ||
| "Sascha-Willems-Nightly": ":alert: :alert: :alert: :alert: :alert: :alert:\nSascha Willems shader nightly status: ${{ job.status }}: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}" | ||
| } | ||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it enough to run these in Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we run also RTX remix and Vulkan CTS on Windows only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we need a GPU? If so, maybe use same pattern as Windows CI testing to use dynamically scaled VMs with pre-existing tooling to build. Would make debugging easier too because consistent env.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If needed we can also enable other OSes later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No GPU needed -- this workflow only compiles shaders to SPIR-V (slangc compiler-only), it does not execute them. A standard GitHub-hosted
windows-2022runner is sufficient.