Skip to content

DNI: test dxvk-remix with struct initialization fixes#9188

Closed
jvepsalainen-nv wants to merge 2 commits intomasterfrom
ci-remix-checkout-struct-init
Closed

DNI: test dxvk-remix with struct initialization fixes#9188
jvepsalainen-nv wants to merge 2 commits intomasterfrom
ci-remix-checkout-struct-init

Conversation

@jvepsalainen-nv
Copy link
Contributor

@jvepsalainen-nv jvepsalainen-nv commented Dec 2, 2025

Test only PR.

Temporarily modify RTX Remix nightly workflow to use NVIDIAGameWorks/dxvk-remix#117, which fixes struct initialization for DirectPathTextures and IndirectPathTextures to comply with stricter Slang compiler rules (error 41024 in v2025.23.1+).

Changes:

  • Fetch and checkout PR 117
  • Remove shallow clone to enable PR fetching
  • Update submodules after checkout

Temporarily modify RTX Remix nightly workflow to use
NVIDIAGameWorks/dxvk-remix#116, which fixes struct initialization
for DirectPathTextures and IndirectPathTextures to comply with
stricter Slang compiler rules (error 41024 in v2025.23.1+).

Switch back using RTX Remix ToT when this PR 116 is merged.

Changes:
- Fetch and checkout PR 116 (init-shader-structs branch)
- Remove shallow clone to enable PR fetching
- Update submodules after checkout

Fixes #8655
@jvepsalainen-nv jvepsalainen-nv self-assigned this Dec 2, 2025
@jvepsalainen-nv
Copy link
Contributor Author

@jvepsalainen-nv jvepsalainen-nv added the pr: non-breaking PRs without breaking changes label Dec 2, 2025
@jvepsalainen-nv jvepsalainen-nv marked this pull request as ready for review December 2, 2025 09:31
@jvepsalainen-nv jvepsalainen-nv requested a review from a team as a code owner December 2, 2025 09:31
@jkwak-work
Copy link
Collaborator

My understanding is that we no longer needs this PR.
I am converting to a draft state for now.
@jvepsalainen-nv , plz close it if that's the case.

@jkwak-work jkwak-work marked this pull request as draft December 3, 2025 20:36
auto-merge was automatically disabled December 3, 2025 20:36

Pull request was converted to draft

Switch from PR #116 to PR #117 which adds Slang 2025.8 compatibility
updates to RTX Remix shaders.
@jvepsalainen-nv
Copy link
Contributor Author

My understanding is that we no longer needs this PR. I am converting to a draft state for now. @jvepsalainen-nv , plz close it if that's the case.

This is not intended to be merged any more. I'm using this PR to test Remix PR NVIDIAGameWorks/dxvk-remix#117

@jvepsalainen-nv jvepsalainen-nv changed the title ci: test dxvk-remix with struct initialization fixes DNI: test dxvk-remix with struct initialization fixes Dec 4, 2025
@jvepsalainen-nv jvepsalainen-nv removed the pr: non-breaking PRs without breaking changes label Dec 4, 2025
@jvepsalainen-nv
Copy link
Contributor Author

Debug only. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants