Fix incorrect use of reinterpret_cast #9484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safocl
force-pushed
the
fix/incorrect-use-reinterpretcast-cuda-prelude
branch
from
3e46ab2 to
e5a6f96
Compare
csyonghe
previously approved these changes
Dec 27, 2025
Collaborator
|
@safocl, there are some CI fixes on master, please merge that in and we can merge this PR :) |
expipiplus1
previously approved these changes
Jan 14, 2026
Collaborator
|
@safocl looks like there's a legit failure in the cuda prelude btw |
auto-merge was automatically disabled
January 14, 2026 07:40
Head branch was pushed to by a user without write access
Contributor
Author
I corrected the typo |
expipiplus1
approved these changes
Jan 15, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The reinterpret_cast cannot be used to cast pointer types that are not pointer-interconvertible. https://eel.is/c++draft/basic.compound#5 https://eel.is/c++draft/conv.qual#2
safocl
force-pushed
the
fix/incorrect-use-reinterpretcast-cuda-prelude
branch
from
6d7ec4f to
792c640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reinterpret_cast cannot be used to cast pointer types that are not pointer-interconvertible.
https://eel.is/c++draft/basic.compound#5
https://eel.is/c++draft/conv.qual#2
https://eel.is/c++draft/basic.lval#11
https://www.en.cppreference.com/w/cpp/language/reinterpret_cast.html