Added ParameterBlock tests to ShaderCursor and fixed the writing code#283
Draft
tdavidovicNV wants to merge 3 commits intomainfrom
Draft
Added ParameterBlock tests to ShaderCursor and fixed the writing code#283tdavidovicNV wants to merge 3 commits intomainfrom
tdavidovicNV wants to merge 3 commits intomainfrom
Conversation
Collaborator
Author
|
This is still failing, will need closer review on MacOS |
Contributor
|
@tdavidovicNV Should this be moved to draft? |
Contributor
|
@tdavidovicNV , can we change this to a draft; otherwise, next Slang maintainers will keep asking the same. |
tdavidovicNV
changed the title
tdavidovicNV
changed the title
tdavidovicNV
force-pushed
the
dev/tdavidovic/add_shader_cursor_pb_tests
branch
from
63e14a3 to
70281ff
Compare
tdavidovicNV
force-pushed
the
dev/tdavidovic/add_shader_cursor_pb_tests
branch
from
70281ff to
5860bba
Compare
Collaborator
Author
|
@jkwak-work I've rebased this and it fails on Metal backend. Less badly than it did on Vulkan, where Slang was just flat out generating invalid code, but it still returns all zeroes rather than reading back values, as it should do and does on all other backends. I've filed a Slang ticket for this. |
Contributor
|
Shall we close this PR or is it being worked on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParameterBlock<T>could only be written ifTwas a struct.