Skip to content

Conversation

@NV-xiaoyongs
Copy link
Contributor

WIP

add neural slang integration tests

@NV-xiaoyongs NV-xiaoyongs requested a review from a team as a code owner January 22, 2026 02:52
@ccummingsNV
Copy link
Contributor

Thought here - does neural.slang have CI? I think we should be shifting to a model where 'integration tests' run in the context of the project being integrated. They can still be triggered by slangpy CI or nightly runs if need be, but we should avoid them living in the slangpy repo.

@NV-xiaoyongs
Copy link
Contributor Author

Thought here - does neural.slang have CI? I think we should be shifting to a model where 'integration tests' run in the context of the project being integrated. They can still be triggered by slangpy CI or nightly runs if need be, but we should avoid them living in the slangpy repo.

Thanks! At the moment there’s no CI for neural.slang. I’m still becoming familiar with the directory structure—can you advise on the right location to place these neural.slang files?

@NV-xiaoyongs NV-xiaoyongs force-pushed the xsun/slangpy/issue_9517.20260110 branch 2 times, most recently from 14bc228 to 34e0b75 Compare January 26, 2026 18:26
@ccummingsNV
Copy link
Contributor

ccummingsNV commented Jan 27, 2026

Thought here - does neural.slang have CI? I think we should be shifting to a model where 'integration tests' run in the context of the project being integrated. They can still be triggered by slangpy CI or nightly runs if need be, but we should avoid them living in the slangpy repo.

Thanks! At the moment there’s no CI for neural.slang. I’m still becoming familiar with the directory structure—can you advise on the right location to place these neural.slang files?

My point, I think, is that slangpy is probably not the right place for neural.slang files. Where is neural.slang actually coming from? I don't see it checked in.

@NV-xiaoyongs
Copy link
Contributor Author

Thought here - does neural.slang have CI? I think we should be shifting to a model where 'integration tests' run in the context of the project being integrated. They can still be triggered by slangpy CI or nightly runs if need be, but we should avoid them living in the slangpy repo.

Thanks! At the moment there’s no CI for neural.slang. I’m still becoming familiar with the directory structure—can you advise on the right location to place these neural.slang files?

My point, I think, is that slangpy is probably not the right place for neural.slang files. Where is neural.slang actually coming from? I don't see it checked in.

Thanks for the clarification. Yeah, we might need to move it to slang. The neural.slang PRs are under review as well.

shader-slang/slang#9512
shader-slang/slang#9713

@NV-xiaoyongs NV-xiaoyongs force-pushed the xsun/slangpy/issue_9517.20260110 branch from 34e0b75 to 01189eb Compare January 28, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants