Fix Texture3D parameters failing with "invalid dimensionality 1" #754
Merged
ccummingsNV merged 6 commits intoshader-slang:mainfrom Feb 4, 2026
Merged
Fix Texture3D parameters failing with "invalid dimensionality 1" #754ccummingsNV merged 6 commits intoshader-slang:mainfrom
ccummingsNV merged 6 commits intoshader-slang:mainfrom
Conversation
ccummingsNV
previously approved these changes
Jan 23, 2026
Contributor
ccummingsNV
left a comment
There was a problem hiding this comment.
Code looks good. If you have time to modify the texture tests to use none-square textures and none-zero coordinates that'd be great - generally good practice with graphics unit tests.
Approved either way though!
Contributor
|
I'll deploy this if the merged version passes. |
ccummingsNV
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #655
TextureMarshall was not overriding resolve_dimensionality(), causing the default implementation to incorrectly calculate call_dimensionality=1 for textures passed as function arguments.
Added resolve_dimensionality() to TextureMarshall that returns: