Update dependencies and add CI test workflow#23
Merged
Conversation
- Replace deprecated structopt with clap v4 - Update webpki-roots to 1.0, env_logger to 0.11, dirs to 6.0 - Remove unused rustls-platform-verifier dependency - Fix clippy warnings in server.rs - Add unit tests for args parsing and common module - Add GitHub Actions CI workflow with test, clippy, and fmt checks - Update existing workflows to use actions/checkout@v4 and dtolnay/rust-toolchain Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
Tests that mutate environment variables (set_var/remove_var) can race when run in parallel, causing intermittent failures. Add serial_test dev-dependency and mark all env-mutating tests with #[serial]. Co-Authored-By: Claude (claude-opus-4-6) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
structopt(unmaintained since 2022) withclapv4webpki-roots1.0,env_logger0.11,dirs6.0, and othersrustls-platform-verifierdependencyci.yml) with test, clippy, and rustfmt checks across Ubuntu, macOS, and Windowsactions/checkout@v4anddtolnay/rust-toolchain(replacing deprecatedactions-rs/toolchain@v1)Test plan
cargo testpasses locally (27 test executions across 3 binaries)cargo clippy -- -D warningspassescargo fmt --all -- --checkpassescargo buildsucceeds🤖 Generated with Claude Code