-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Ds4 speaker audio base #3328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ds4 speaker audio base #3328
Conversation
PR submitted to your branch for GUI |
|
Whoops, my bad |
thanks, the only other thing I'm not sure of is if this how to get the SDL device ID from the chosen device name devId = static_cast(std::stoul(port_name)); |
Oh, that code was from shadow's mic PR. If it doesn't work, just lmk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, two comments (also needs a rebase).
Audio dev
* fixed RetrieveNetmask for windows * clang..
* implement V_ALIGNBYTE_B32 and V_ALIGNBIT_B32 * fix mask * uncomment alignbit
…4-emu#3336) Removed redundancies from CheatsPatches::onSaveButtonClicked()
…3327) * shader_recompiler: Remove remnants of old discard Also constant propagate conditional discard if condition is constant * resource_tracking_pass: Rework sharp tracking for robustness * resource_tracking_pass: Add source dominance analysis When reachability is not enough to prune source list, check if a source dominates all other sources * resource_tracking_pass: Fix immediate check How did this work before * resource_tracking_pass: Remove unused template type * readlane_elimination_pass: Don't add phi when all args are the same New sharp tracking exposed some bad sources coming on sampler sharps with aniso disable pattern that also were part of readlane pattern, fix tracking by removing the unnecessary phis inbetween * resource_tracking_pass: Allow phi in disable aniso pattern * resource_tracking_pass: Handle not valid buffer sharp and more phi in aniso pattern
* Socket support for read/write/fstat * Sockets are now files * Fix ssize_t for windows * Return posix error codes in net functions
* fix patches * fix linux? * + mask, mask_jump32 | - insideMetadata
…ller (shadps4-emu#3169) * initial commit - not cleanup yet, not usable with imGUI * Ugly solution to working with ImGUI * Populate the default controller labels * Add remove default button * missing tr calls * edit imgui flag after updating * Refactor * Update sirit
* New translations en_us.ts (Catalan) * New translations en_us.ts (Norwegian Bokmal) * New translations en_us.ts (Italian) * New translations en_us.ts (Swedish) * New translations en_us.ts (Portuguese, Brazilian) * New translations en_us.ts (Serbian (Latin)) * New translations en_us.ts (Ukrainian) * New translations en_us.ts (Russian) * New translations en_us.ts (Chinese Simplified) * New translations en_us.ts (Swedish) * New translations en_us.ts (Turkish)
* Store platform-specific level in a separate variable So the level logged in the getsockopt/setsockopt unreachable is actually useful in cases where the level is unknown. * Define ORBIS_NET_IPPROTO_IPV6 Not implemented yet, but since it's known we might as well add it. * Fix error codes Our libSceNet code expects accurate ORBIS_NET_E* errors, while the sys_net code returns ORBIS_NET_ERROR_* errors. * Remove duplicate getsockname implementation * Use separate mutex for ReceivePacket calls Calls to ReceivePacket shouldn't block other socket functions, and allowing them to block these functions frequently causes deadlocks in games that use multiple threads for socket behaviors. That said, concurrent receives are still a potential issue, so the function should still have a mutex. * Add missing error codes * Clang * Minor nit Not sure why these were left separate from the rest of the net errnos * Set __Error() in ConvertReturnErrorCode Because the new error values are positive, the logic of "negative return is an error" doesn't work anymore. The easiest fix, while retaining corrected error values, is to just set __Error() in ConvertReturnErrorCode, and have that return -1 instead. I also added some formatting fixes here too. * Set errno on stubbed P2P socket error returns. Otherwise the errno is just whatever was set by a previous failing function, which may cause issues in some games. I used EAGAIN here since it appears to be valid for all three of these functions, but this can be changed if requested. * Fix missed error returns * Fix socket methods in file_system Missed these
* Implement V_CMP_GT_U64 * Add GroupAny * Use GroupAny * Add assert * clang
* make shadps4 default repo for patches * if present, put shadPS4 patches on top of listview * Update cheats_patches.cpp --------- Co-authored-by: rainmakerv2 <[email protected]>
* Update sdl_audio.cpp * clang (I hope) * clang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See updates in sdl_audio.cpp
Your PR doesn't seem to be rebased right, it includes a bunch of commits from main. |
How do I fix the rebase issue? |
Fixed to match original commit on head branch
Fixing branch graph
…-Speaker-Audio-Base
I'm moving this to a new PR. This one is too far gone... |
See #3607 for new pr |
Basic functionality that separates the pad speaker channel from the rest of the audio. This does not include gui components, which need to be implemented.