Log user CPU, total RAM, and OS #3402
Conversation
|
If i remember correctly we have used this library before and for some reason it was causing big slowdowns |
|
Maybe the RAM should be rounded instead of displaying the exact value, and also I feel like it's missing a space |
|
I added the space and the rounding, and will try to spend some time this weekend to see if there are any slowdowns on this action. |
|
yes if you checked a year ago that was added and removed because it was causing issues , dunno if they have fixed them |
|
Looks like the Windows SDL actions are broken. They complain about needing the various hwinfo dlls, which don't appear to be included in the downloaded action? |
|
Seems like the same applies to the Windows Qt actions too. |
|
setting set(HWINFO_STATIC ON) as pointed out by @Osyotr removes the need for external dlls, so the windows issues are fixed. Also pointed the submodule to my fork of the library temporarily to add the missing include and fix mac building. This is ready for performance testing now, I can do some this weekend, but would appreciate if anyone else can. |
|
Doesn't seem to cause any performance regression in Bloodborne (CUSA00900) PR: Main: |
|
Did some testing on the games I have that I can play long sessions on (Bloodborne, Gravity Rush Remastered, South Park Stick of Truth) and all of them perform seemingly just like main after 20-30 minutes playing each. is there something specific that used to trigger the issues with this lib that I should be testing? I can't seem to find the PR that reverted it |
|
I haven't noticed performance being worse than main on this PR, could this be merged ? |
|
fork created at https://github.com/shadps4-emu/ext-hwinfo rainmaker you can do your changes there and change the repo |
|
PR submitted to https://github.com/shadps4-emu/ext-hwinfo. will wait on that before switching the repo |
|
done |
|
Done changing to submodule repo to the shadps4 fork |
* cpu info Update cpu_info.h Revert "Update cpu_info.h" This reverts commit 6db3814. Revert "cpu info" This reverts commit cfecdf6. hardware info * log OS * Round RAM, add space * switch temporarily to local fork * Update CMakeLists.txt * set shallow = true for submodule * Log logical cores as well * point submodule to shadps4 fork
* cpu info Update cpu_info.h Revert "Update cpu_info.h" This reverts commit 6db3814. Revert "cpu info" This reverts commit cfecdf6. hardware info * log OS * Round RAM, add space * switch temporarily to local fork * Update CMakeLists.txt * set shallow = true for submodule * Log logical cores as well * point submodule to shadps4 fork # Conflicts: # CMakeLists.txt
Closes #3401
This logs the CPU, RAM, and OS on emulator startup with this submodule: https://github.com/lfreist/hwinfo
Having spent a bunch of time in bloodborne-chat, I can agree that this bit of logging actually helps quite a bit for those trying to provide help.
Mac build error is because of the submodule (seems like just a missing include?). If this is otherwise okay, can someone fork the submodule to add it in?