Skip to content

fix(api): fix device name update endpoint & usage #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahradelahi merged 1 commit into from
Dec 23, 2025
Merged

fix(api): fix device name update endpoint & usage #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cloudflare/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ func (w *WarpAPI) UpdateAccount(authToken, deviceID, license string) (model.Iden
}

func (w *WarpAPI) UpdateBoundDevice(authToken, deviceID, otherDeviceID, name string, active bool) (model.IdentityDevice, error) {
reqUrl := fmt.Sprintf("%s/reg/%s/account/reg/%s", apiBase, deviceID, otherDeviceID)
reqUrl := fmt.Sprintf("%s/reg/%s/account/devices/%s", apiBase, deviceID, otherDeviceID)
method := "PATCH"

data := map[string]interface{}{
Expand Down Expand Up @@ -370,11 +370,11 @@ func (w *WarpAPI) UpdateBoundDevice(authToken, deviceID, otherDeviceID, name str
return rspData, nil
}

func (w *WarpAPI) UpdateSourceDevice(authToken, deviceID, publicKey string) (model.Identity, error) {
func (w *WarpAPI) UpdateSourceDevice(authToken, deviceID string, data map[string]interface{}) (model.Identity, error) {
reqUrl := fmt.Sprintf("%s/reg/%s", apiBase, deviceID)
method := "PATCH"

jsonBody, err := json.Marshal(map[string]interface{}{"key": publicKey})
jsonBody, err := json.Marshal(data)
if err != nil {
return model.Identity{}, err
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ func runUpdate() error {

// Update device name if provided
if name != "" {
_, err = warpAPI.UpdateBoundDevice(identity.Token, identity.ID, identity.ID, name, true)
_, err = warpAPI.UpdateSourceDevice(identity.Token, identity.ID, map[string]interface{}{"name": name})
if err != nil {
return fmt.Errorf("failed to update device name: %w", err)
}
Expand Down
Loading