fix: Avoid audio streams filtering and use AdaptationSetCriteria instead #9457
+13
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
Member
Author
|
@joeyparrish this is related to our chat conversation about track filtering |
avelad
force-pushed
the
audio-filtering
branch
from
9f720ae to
dd1b64a
Compare
Collaborator
|
Incremental code coverage: 100.00% |
tykus160
approved these changes
Dec 3, 2025
Member
|
I don't understand the thinking behind this PR, and it is causing a merge conflict with another one I'm working on. (#9452) Why would we not pick the best supported track out of a set of redundant ones? (Same sample rate, language, role, etc, but different codec and/or bitrate) |
Member
Author
Apps should be able to choose |
avelad
added a commit
that referenced
this pull request
Dec 15, 2025
…ead (#9457) This is part to remove dontChooseCodecs config in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part to remove dontChooseCodecs config in the future.