You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix workflow files for new react_on_rails/ directory structure
Updated CI workflows to reference Gemfile.lock and run bundle/rake commands
from the correct location after moving files into react_on_rails/.
Changes:
- integration-tests.yml: Update cache paths, bundle install, and rake commands
- examples.yml: Update cache path for Gemfile.lock
- gem-tests.yml: Update cache path and bundle install command
- CONTRIBUTING.md: Update example paths in documentation
All bundle commands now run with `cd react_on_rails` prefix, and cache keys
use `react_on_rails/Gemfile.lock` instead of `Gemfile.lock` at root.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -54,7 +54,7 @@ It's critical to configure your IDE/editor to ignore certain directories. Otherw
54
54
55
55
The [`react_on_rails/spec/dummy` app](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails/spec/dummy) is an example of the various setup techniques you can use with the gem.
56
56
57
-
There are also two such apps for React on Rails Pro: [one using the Node renderer](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails_pro/react_on_rails/spec/dummy) and [one using ExecJS](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails_pro/spec/execjs-compatible-dummy).
57
+
There are also two such apps for React on Rails Pro: [one using the Node renderer](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails_pro/spec/dummy) and [one using ExecJS](https://github.com/shakacode/react_on_rails/blob/master/react_on_rails_pro/spec/execjs-compatible-dummy).
58
58
59
59
When you add a new feature, consider adding an example demonstrating it to the example apps.
60
60
@@ -124,8 +124,8 @@ When you run `yalc push`, you'll get an informative message
Don't forget you may need to run yarn after adding packages with yalc to install/update dependencies/bin scripts.
130
130
```
131
131
@@ -136,7 +136,7 @@ This is the approach `react_on_rails/spec/dummy` apps use, so you can also look
136
136
### Example: Testing NPM changes with the dummy app
137
137
138
138
1. Add `console.log('Hello!')` to [clientStartup.ts, function render](https://github.com/shakacode/react_on_rails/blob/master/packages/react-on-rails/src/clientStartup.ts) in `/packages/react-on-rails/src/clientStartup.ts` to confirm we're getting an update to the node package client-side. Do the same for function `serverRenderReactComponent` in [/packages/react-on-rails/src/serverRenderReactComponent.ts](https://github.com/shakacode/react_on_rails/blob/master/packages/react-on-rails/src/serverRenderReactComponent.ts).
139
-
2. Refresh the browser if the server is already running or start the server using `foreman start` from `react_on_rails/react_on_rails/spec/dummy` and navigate to `http://localhost:3000/`. You will now see the `Hello!` message printed in the browser's console. If you did not see that message, then review the steps above for the workflow of making changes and pushing them via yalc.
139
+
2. Refresh the browser if the server is already running or start the server using `foreman start` from `react_on_rails/spec/dummy` and navigate to `http://localhost:3000/`. You will now see the `Hello!` message printed in the browser's console. If you did not see that message, then review the steps above for the workflow of making changes and pushing them via yalc.
0 commit comments