Skip to content

Commit 585356a

Browse files
justin808claude
andcommitted
Address code review feedback: workspace protocol and file organization
Based on code review feedback, this commit addresses: 1. **Use workspace protocol for internal dependencies** - Changed react-on-rails-pro-node-renderer package.json to use workspace:* instead of hardcoded version numbers - This prevents needing to update multiple package.json files when bumping versions in the monorepo 2. **Move analysis documentation to proper location** - Moved PHASE_*.md files to .claude/docs/analysis/ (4 files) - Moved other analysis docs: AI_AGENT_INSTRUCTIONS.md, CI_FIXES_APPLIED.md, CI_OPTIMIZATION_SUMMARY.md, RSPACK_IMPLEMENTATION.md - Reduces root directory clutter per CLAUDE.md guidelines - Keeps MONOREPO_MIGRATION_STATUS.md at root for quick reference 3. **Verified yalc publish works correctly** - Manually tested yarn run yalc:publish per CLAUDE.md requirements - Confirmed react-on-rails and react-on-rails-pro build artifacts exist at expected paths (lib/ReactOnRails.full.js) - node-renderer shows expected build failure message but publishes successfully (pre-existing TypeScript errors acknowledged) Follow-up items tracked in PR for separate commits: - Fix TypeScript build errors in node-renderer (add .js extensions) - Re-enable ESLint rules once TS builds work - Review peer vs regular dependencies for error monitoring libs - Add workspace structure validation tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 4a3eacb commit 585356a

File tree

9 files changed

+2
-2
lines changed

9 files changed

+2
-2
lines changed
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

packages/react-on-rails-pro-node-renderer/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
"lockfile": "^1.0.4",
4040
"pino": "^9.0.0",
4141
"pino-pretty": "^13.0.0",
42-
"react-on-rails": "16.2.0-beta.10",
43-
"react-on-rails-pro": "16.2.0-beta.10"
42+
"react-on-rails": "workspace:*",
43+
"react-on-rails-pro": "workspace:*"
4444
},
4545
"devDependencies": {
4646
"@honeybadger-io/js": "^6.10.1",

0 commit comments

Comments
 (0)