Commit 585356a
Address code review feedback: workspace protocol and file organization
Based on code review feedback, this commit addresses:
1. **Use workspace protocol for internal dependencies**
- Changed react-on-rails-pro-node-renderer package.json to use
workspace:* instead of hardcoded version numbers
- This prevents needing to update multiple package.json files when
bumping versions in the monorepo
2. **Move analysis documentation to proper location**
- Moved PHASE_*.md files to .claude/docs/analysis/ (4 files)
- Moved other analysis docs: AI_AGENT_INSTRUCTIONS.md,
CI_FIXES_APPLIED.md, CI_OPTIMIZATION_SUMMARY.md,
RSPACK_IMPLEMENTATION.md
- Reduces root directory clutter per CLAUDE.md guidelines
- Keeps MONOREPO_MIGRATION_STATUS.md at root for quick reference
3. **Verified yalc publish works correctly**
- Manually tested yarn run yalc:publish per CLAUDE.md requirements
- Confirmed react-on-rails and react-on-rails-pro build artifacts
exist at expected paths (lib/ReactOnRails.full.js)
- node-renderer shows expected build failure message but publishes
successfully (pre-existing TypeScript errors acknowledged)
Follow-up items tracked in PR for separate commits:
- Fix TypeScript build errors in node-renderer (add .js extensions)
- Re-enable ESLint rules once TS builds work
- Review peer vs regular dependencies for error monitoring libs
- Add workspace structure validation tests
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 4a3eacb commit 585356a
File tree
9 files changed
+2
-2
lines changed- .claude/docs/analysis
- packages/react-on-rails-pro-node-renderer
9 files changed
+2
-2
lines changedFile renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
| 42 | + | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
0 commit comments