Skip to content

Commit 6fc7d32

Browse files
justin808claude
andcommitted
Fix matrix configuration to use static include entries
The previous approach used conditional expressions within the include section, which caused GitHub Actions to create matrix entries with false/empty values when conditions weren't met. This resulted in a (false, false, false) matrix entry that failed. Solution: Changed to match the pattern used in gem-tests.yml and examples.yml - use static entries in include section and rely solely on exclude section for conditional logic. Changes: - Converted matrix from array-based to include-based for both jobs - Made include entries static (always add both latest and minimum) - Keep exclude section to conditionally remove minimum on PRs This ensures only valid matrix combinations are created. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent d8c3230 commit 6fc7d32

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

.github/workflows/integration-tests.yml

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,15 @@ jobs:
6565
github.ref == 'refs/heads/master' || github.event_name == 'workflow_dispatch' || needs.detect-changes.outputs.run_dummy_tests == 'true'
6666
strategy:
6767
matrix:
68-
ruby-version: ['3.4']
69-
node-version: ['22']
70-
dependency-level: ['latest']
7168
include:
72-
# Skip minimum dependency matrix on regular PRs (run only on master/workflow_dispatch/force_run/full-ci label)
73-
- ruby-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '3.2'}}
74-
node-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '20'}}
75-
dependency-level: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && 'minimum'}}
69+
# Always run: Latest versions (fast feedback on PRs)
70+
- ruby-version: '3.4'
71+
node-version: '22'
72+
dependency-level: 'latest'
73+
# Master and workflow_dispatch: Minimum supported versions (full coverage)
74+
- ruby-version: '3.2'
75+
node-version: '20'
76+
dependency-level: 'minimum'
7677
exclude:
7778
# Skip minimum dependency matrix on regular PRs (run only on master/workflow_dispatch/force_run/full-ci label)
7879
- ruby-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && inputs.force_run != true && needs.detect-changes.outputs.has_full_ci_label != 'true' && '3.2' || '' }}
@@ -153,14 +154,15 @@ jobs:
153154
github.ref == 'refs/heads/master' || github.event_name == 'workflow_dispatch' || needs.detect-changes.outputs.run_dummy_tests == 'true'
154155
strategy:
155156
matrix:
156-
ruby-version: ['3.4']
157-
node-version: ['22']
158-
dependency-level: ['latest']
159157
include:
160-
# Skip minimum dependency matrix on regular PRs (run only on master/workflow_dispatch/force_run/full-ci label)
161-
- ruby-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '3.2'}}
162-
node-version: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && '20'}}
163-
dependency-level: ${{ (github.ref == 'refs/heads/master' || inputs.force_run == true || needs.detect-changes.outputs.has_full_ci_label == 'true') && 'minimum'}}
158+
# Always run: Latest versions (fast feedback on PRs)
159+
- ruby-version: '3.4'
160+
node-version: '22'
161+
dependency-level: 'latest'
162+
# Master and workflow_dispatch: Minimum supported versions (full coverage)
163+
- ruby-version: '3.2'
164+
node-version: '20'
165+
dependency-level: 'minimum'
164166
exclude:
165167
# Skip minimum dependency matrix on regular PRs (run only on master/workflow_dispatch/force_run/full-ci label)
166168
- ruby-version: ${{ github.event_name == 'pull_request' && github.ref != 'refs/heads/master' && inputs.force_run != true && needs.detect-changes.outputs.has_full_ci_label != 'true' && '3.2' || '' }}

0 commit comments

Comments
 (0)