Skip to content

Commit da797d4

Browse files
Fix handleRenderRequest tests to use new response structure
Update all test assertions to access the response property from the returned object, as handleRenderRequest now returns { response, executionContext } instead of the response directly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent c09199e commit da797d4

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

react_on_rails_pro/packages/node-renderer/tests/handleRenderRequest.test.ts

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe(testName, () => {
7878
],
7979
});
8080

81-
expect(result).toEqual(renderResult);
81+
expect(result.response).toEqual(renderResult);
8282
expect(
8383
hasVMContextForBundle(path.resolve(__dirname, `./tmp/${testName}/1495063024898/1495063024898.js`)),
8484
).toBeTruthy();
@@ -92,7 +92,7 @@ describe(testName, () => {
9292
bundleTimestamp: BUNDLE_TIMESTAMP,
9393
});
9494

95-
expect(result).toEqual({
95+
expect(result.response).toEqual({
9696
status: 410,
9797
headers: { 'Cache-Control': 'no-cache, no-store, max-age=0, must-revalidate' },
9898
data: 'No bundle uploaded',
@@ -108,7 +108,7 @@ describe(testName, () => {
108108
bundleTimestamp: BUNDLE_TIMESTAMP,
109109
});
110110

111-
expect(result).toEqual(renderResult);
111+
expect(result.response).toEqual(renderResult);
112112
});
113113

114114
test('If lockfile exists, and is stale', async () => {
@@ -133,7 +133,7 @@ describe(testName, () => {
133133
],
134134
});
135135

136-
expect(result).toEqual(renderResult);
136+
expect(result.response).toEqual(renderResult);
137137
expect(
138138
hasVMContextForBundle(path.resolve(__dirname, `./tmp/${testName}/1495063024898/1495063024898.js`)),
139139
).toBeTruthy();
@@ -165,7 +165,7 @@ describe(testName, () => {
165165
],
166166
});
167167

168-
expect(result).toEqual(renderResult);
168+
expect(result.response).toEqual(renderResult);
169169
expect(
170170
hasVMContextForBundle(path.resolve(__dirname, `./tmp/${testName}/1495063024898/1495063024898.js`)),
171171
).toBeTruthy();
@@ -199,7 +199,7 @@ describe(testName, () => {
199199
],
200200
});
201201

202-
expect(result).toEqual(renderResult);
202+
expect(result.response).toEqual(renderResult);
203203
// only the primary bundle should be in the VM context
204204
// The secondary bundle will be processed only if the rendering request requests it
205205
expect(
@@ -254,7 +254,7 @@ describe(testName, () => {
254254
assetsToCopy: additionalAssets,
255255
});
256256

257-
expect(result).toEqual(renderResult);
257+
expect(result.response).toEqual(renderResult);
258258

259259
// Only the primary bundle should be in the VM context
260260
// The secondary bundle will be processed only if the rendering request requests it
@@ -310,7 +310,7 @@ describe(testName, () => {
310310
dependencyBundleTimestamps: [SECONDARY_BUNDLE_TIMESTAMP],
311311
});
312312

313-
expect(result).toEqual({
313+
expect(result.response).toEqual({
314314
status: 410,
315315
headers: { 'Cache-Control': 'no-cache, no-store, max-age=0, must-revalidate' },
316316
data: 'No bundle uploaded',
@@ -328,7 +328,7 @@ describe(testName, () => {
328328
dependencyBundleTimestamps: [SECONDARY_BUNDLE_TIMESTAMP],
329329
});
330330

331-
expect(result).toEqual(renderResult);
331+
expect(result.response).toEqual(renderResult);
332332
});
333333

334334
test('rendering request can call runOnOtherBundle', async () => {
@@ -348,7 +348,7 @@ describe(testName, () => {
348348
dependencyBundleTimestamps: [SECONDARY_BUNDLE_TIMESTAMP],
349349
});
350350

351-
expect(result).toEqual(renderResultFromBothBundles);
351+
expect(result.response).toEqual(renderResultFromBothBundles);
352352
// Both bundles should be in the VM context
353353
expect(
354354
hasVMContextForBundle(path.resolve(__dirname, `./tmp/${testName}/1495063024898/1495063024898.js`)),
@@ -370,7 +370,7 @@ describe(testName, () => {
370370
bundleTimestamp: BUNDLE_TIMESTAMP,
371371
});
372372

373-
expect(result).toEqual({
373+
expect(result.response).toEqual({
374374
status: 200,
375375
headers: { 'Cache-Control': 'public, max-age=31536000' },
376376
data: renderingRequest,
@@ -402,7 +402,7 @@ describe(testName, () => {
402402
bundleTimestamp: BUNDLE_TIMESTAMP,
403403
});
404404

405-
expect(result).toEqual({
405+
expect(result.response).toEqual({
406406
status: 200,
407407
headers: { 'Cache-Control': 'public, max-age=31536000' },
408408
data: JSON.stringify('undefined'),
@@ -420,7 +420,7 @@ describe(testName, () => {
420420
dependencyBundleTimestamps: [SECONDARY_BUNDLE_TIMESTAMP],
421421
});
422422

423-
expect(result).toEqual({
423+
expect(result.response).toEqual({
424424
status: 410,
425425
headers: { 'Cache-Control': 'no-cache, no-store, max-age=0, must-revalidate' },
426426
data: 'No bundle uploaded',

0 commit comments

Comments
 (0)