Skip to content

Update generators to add fallback: { stream: false } to webpack configs #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Update generators to add fallback: { stream: false } to webpack configs #1676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e20058e
Update Webpack configuration to remove stream-browserify dependency
AbanoubGhadban Jan 15, 2025
2d8c409
Update CHANGELOG.md to document Webpack configuration fix
AbanoubGhadban Jan 15, 2025
0e16e0b
revert a change made by mistake
AbanoubGhadban Jan 15, 2025
e8aeb57
add comment that explains when stream-browserify is needed
AbanoubGhadban Jan 15, 2025
2432b86
add another comment
AbanoubGhadban Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/generators/react_on_rails/templates/base/base/config/webpack/webpackConfig.js.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ const serverWebpackConfig = require('./serverWebpackConfig');
const webpackConfig = (envSpecific) => {
const clientConfig = clientWebpackConfig();
const serverConfig = serverWebpackConfig();
clientConfig.resolve.fallback = { stream: false };
// Remove the next line if you used "node" target in serverWebpackConfig.js
serverConfig.resolve.fallback = { stream: false };

if (envSpecific) {
envSpecific(clientConfig, serverConfig);
Expand Down
1 change: 0 additions & 1 deletion spec/dummy/config/webpack/alias.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ module.exports = {
resolve: {
alias: {
Assets: resolve(__dirname, '..', '..', 'client', 'app', 'assets'),
stream: 'stream-browserify',
},
},
};
4 changes: 3 additions & 1 deletion spec/dummy/config/webpack/webpackConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ const serverWebpackConfig = require('./serverWebpackConfig');
const webpackConfig = (envSpecific) => {
const clientConfig = clientWebpackConfig();
const serverConfig = serverWebpackConfig();
clientConfig.resolve.fallback = { stream: require.resolve('stream-browserify') };
clientConfig.resolve.fallback = { stream: false };
// Remove the next line if you used "node" target in serverWebpackConfig.js
serverConfig.resolve.fallback = { stream: false };

if (envSpecific) {
envSpecific(clientConfig, serverConfig);
Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"format": "cd ../.. && yarn start format",
"test": "yarn run build:test && yarn run lint && rspec",
"build:test": "rm -rf public/webpack/test && yarn build:rescript && RAILS_ENV=test NODE_ENV=test bin/shakapacker",
"build:dev": "rm -rf public/webpack/development && yarn build:rescript && RAILS_ENV=development NODE_ENV=development bin/shakapacker --watch",
"build:dev": "rm -rf public/webpack/development && yarn build:rescript && RAILS_ENV=development NODE_ENV=development bin/shakapacker",
"build:dev:server": "rm -rf public/webpack/development && yarn build:rescript && RAILS_ENV=development NODE_ENV=development bin/shakapacker --watch",
"build:dev:watch": "rescript build -w && RAILS_ENV=development NODE_ENV=development bin/shakapacker --watch",
"build:clean": "yarn build:rescript && rm -rf public/webpack || true",
Expand Down
Loading