Skip to content

Mark react-on-rails-rsc peerdep as optional #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025
Merged

Mark react-on-rails-rsc peerdep as optional #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions knip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ const config: KnipConfig = {
'@eslint/js',
// used by Jest
'jsdom',
// This is an optional peer dependency because users without RSC don't need it
// but Knip doesn't like such dependencies to be referenced directly in code
'react-on-rails-rsc',
],
},
'spec/dummy': {
Expand Down
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@
"react-dom": ">= 16",
"react-on-rails-rsc": "19.0.2"
},
"peerDependenciesMeta": {
"react-on-rails-rsc": {
"optional": true
}
},
"files": [
"node_package/lib"
],
Expand Down
Loading