-
-
Notifications
You must be signed in to change notification settings - Fork 638
Have the lint job its own cache keys #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
d1f01da
a852f43
40e21f0
5c1f9c2
f6e5362
4f9b4ea
a089e05
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,3 +62,13 @@ if (typeof window !== 'undefined') { | |
| global.ReadableStream = ReadableStream; | ||
| global.ReadableStreamDefaultReader = ReadableStreamDefaultReader; | ||
| } | ||
|
|
||
| global.console.log('All calls to console have been disabled in jest.setup.js'); | ||
|
||
|
|
||
| global.console = { | ||
| log: jest.fn(), | ||
| error: jest.fn(), | ||
| warn: jest.fn(), | ||
| info: jest.fn(), | ||
| debug: jest.fn(), | ||
| }; | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| import ReactOnRails from 'react-on-rails'; | ||
|
|
||
| test('ReactOnRails', () => { | ||
| ReactOnRails.register({}); | ||
| expect(() => { | ||
| ReactOnRails.register({}); | ||
| }).not.toThrow(); | ||
| }); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,7 @@ | ||
| const ReactOnRails = require('react-on-rails').default; | ||
|
|
||
| test('ReactOnRails', () => { | ||
| ReactOnRails.register({}); | ||
| expect(() => { | ||
| ReactOnRails.register({}); | ||
| }).not.toThrow(); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newest makes sense, but a separate
-lintone doesn't to me.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newest didn't work. That's why one of the commits is named "newest cache is still borked". It results in the gems being reinstalled just like the oldest cache key did.
The newest cache key works for other jobs, like Rspec, so I have no idea what is wrong.
All I know is that the lint key fixes the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.