-
-
Notifications
You must be signed in to change notification settings - Fork 637
update JetBrains logo to new brand assets #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace old GitHub-hosted JetBrains logo with new official brand assets
- Update link to point to JetBrains OpenSource page as recommended
WalkthroughUpdated the JetBrains supporter entry in README.md: changed link to https://jb.gg/OpenSource, swapped the logo to JetBrains’ official CDN asset, and added inline right margin styling; logo height remains 120px. No other files or entries were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
README.md (3)
123-123: Avoid inline styles; keep supporter logo spacing consistentOnly the JetBrains anchor uses an inline margin. Consider removing it or standardizing spacing across all supporter entries for consistency.
Apply this diff to remove the inline style (or replicate a consistent approach across all entries):
-<a href="https://jb.gg/OpenSource" style="margin-right: 20px;"> +<a href="https://jb.gg/OpenSource">
124-124: Prefer SVG (crisper, smaller) and verify dark-mode suitabilityIf JetBrains provides an SVG for this logo, prefer it for scalability and sharpness on all DPIs. Also verify the chosen asset has a transparent background and looks correct in GitHub dark mode.
Example change (verify the exact SVG URL exists in their brand kit before applying):
- <img src="https://resources.jetbrains.com/storage/products/company/brand/logos/jetbrains.png" alt="JetBrains" height="120px"> + <img src="https://resources.jetbrains.com/storage/products/company/brand/logos/jetbrains.svg" alt="JetBrains" height="120px">If a dark/light variant is recommended by JetBrains, consider a
<picture>withprefers-color-scheme, similar to other supporter entries.
124-124: Minor a11y nit: clarify alt text (optional)Alt="JetBrains" is fine. Optionally make it slightly more descriptive for non-visual readers.
- <img src="https://resources.jetbrains.com/storage/products/company/brand/logos/jetbrains.png" alt="JetBrains" height="120px"> + <img src="https://resources.jetbrains.com/storage/products/company/brand/logos/jetbrains.png" alt="JetBrains logo" height="120px">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: rspec-package-tests (oldest)
- GitHub Check: examples (newest)
- GitHub Check: examples (oldest)
- GitHub Check: build-dummy-app-webpack-test-bundles (oldest)
- GitHub Check: build-dummy-app-webpack-test-bundles (newest)
🔇 Additional comments (1)
README.md (1)
123-124: Core update LGTM: correct link and official assetThe JetBrains link now points to https://jb.gg/OpenSource and the logo uses the official brand asset. This aligns with JetBrains’ OSS branding guidance.
Summary
Updates the jetbrains logo with the new one.
This update was requested by JetBrains as part of their brand refresh to showcase continued collaboration
Pull Request checklist
Remove this line after checking all the items here. If the item is not applicable to the PR, both check it out and wrap it by
~.Add the CHANGELOG entry at the top of the file.
Other Information
Remove this paragraph and mention any other important and relevant information such as benchmarks.
This change is
Summary by CodeRabbit