Fix failing install generator tests for v16#1784

Closed

ihabadham wants to merge 137 commits intomasterfrom

ihab-pr-1770-breaking-changes-for-v16

Commits on Sep 16, 2025

generator: switch install prerequisite from yarn to npm and update specs

ihabadham
authored and
justin808
committed
generator: auto-install Shakapacker if not installed

ihabadham
authored and
justin808
committed
generator: adopt example bin/dev in generator and dummy app

ihabadham
authored and
justin808
committed
enable auto-registered bundles by default - set components_subdirectory - set nested_entries to true

ihabadham
authored and
justin808
committed
ci: fix failures because of ARGV and exits

ihabadham
authored and
justin808
committed
ci: correct rubocop offenses

ihabadham
authored and
justin808
committed
disable auto_load_bundle by default

ihabadham
authored and
justin808
committed
Resolve conflicts with Justin's PR #1769 before rebase

ihabadham
authored and
justin808
committed
let shakapacker handle package manager for us

ihabadham
authored and
justin808
committed
refactor: convert Procfile templates from dynamic to static shakapacker references

ihabadham
authored and
justin808
committed
fix: add missing Procfile variants to spec/dummy

ihabadham
authored and
justin808
committed
rename webpackConfig to generateWebpackConfigs (#1772)

Judahmeek
authored and
justin808
committed
generator: refactor templates to default to auto registration

ihabadham
authored and
justin808
committed
ci: linting js

ihabadham
authored and
justin808
committed
ci: fix redux generator still creates components in the old structure

ihabadham
authored and
justin808
committed
linting

ihabadham
authored and
justin808
committed
ci

ihabadham
authored and
justin808
committed
Fix CI failures: update generator tests and Redux auto-registration

ihabadham
authored and
justin808
committed
ci: fix import paths

ihabadham
authored and
justin808
committed
linting

ihabadham
authored and
justin808
committed
fix: remove double registration from server-bundle.js template

ihabadham
authored and
justin808
committed
refactor: adopt client/server component structure per documentation

ihabadham
authored and
justin808
committed
fix: remove unused Procfile.dev-static and fix backward compatibility

ihabadham
authored and
justin808
committed
fix: improve error handling in bin/dev scripts per CodeRabbit feedback

ihabadham
authored and
justin808
committed
fix redux generator for auto-registration

ihabadham
authored and
justin808
committed
refactor generators: eliminate wasteful cleanup

ihabadham
authored and
justin808
committed
linting

ihabadham
authored and
justin808
committed
ci: fix old import paths and generator examples

ihabadham
authored and
justin808
committed
ci: fix incomplete bin/dev script test execution by adding missing mocks

ihabadham
authored and
justin808
committed
ci: linting

ihabadham
authored and
justin808
committed
ci: fix import paths

ihabadham
authored and
justin808
committed
refactor: replace duplicate bin/dev with symlink to generator template

justin808
and
claude
committed
feat: refactor bin/dev and add kill command

justin808
and
claude
committed
fix: clean up overmind socket file in bin/dev kill command

justin808
and
claude
committed
fix: auto-clean stale overmind sockets on startup

justin808
and
claude
committed
improve: expand stale file cleanup to include Rails server.pid

justin808
and
claude
committed
improve: smart webpack.config.js handling in generator

justin808
and
claude
committed
fix: implement robust Shakapacker webpack.config.js detection

justin808
and
claude
committed
fix: eliminate webpack.config.js conflict prompt for standard configs

justin808
and
claude
committed
Refactor bin/dev to use ReactOnRails::Dev classes with clear Procfile management

justin808
and
claude
committed
Fix spec_helper require in ReactOnRails::Dev spec files

justin808
and
claude
committed
Add proper spec_helper require to ReactOnRails::Dev specs

justin808
and
claude
committed
Fix specs and add verbose option for pack generation

justin808
and
claude
committed
Fix CI module loading and linting issues

justin808
and
claude
committed
Fix bin/dev script test expectations

justin808
and
claude
committed
Fix line length violations in Dev specs

justin808
and
claude
committed
Fix file existence checks in adapt_for_older_shakapacker_generator

justin808
and
claude
committed
Fix CSS module configuration issues in generator examples

justin808
and
claude
committed
Improve CSS loader configuration in webpack common config
justin808
committed
Fix RuboCop style issues with guard clauses
justin808
committed
Simplify CSS loader configuration in webpack common config
justin808
committed
Remove CSS imports to fix webpack compilation issues
justin808
committed
Add RuboCop overrides for justified Dev module violations
justin808
committed
Refactor Dev modules for better code quality and fix post-install messages
justin808
committed
Fix timing race condition in locales_to_js_spec.rb
justin808
committed
Fix Net::ReadTimeout error in selenium_logger.rb
justin808
committed
Fix test logic for up-to-date file detection in locales_to_js_spec.rb
justin808
committed
Address PR review comments
justin808
committed
Fix CSS modules implementation based on review feedback
justin808
committed
Fix CSS modules support in generators
justin808
committed
Add proper CSS modules webpack configuration
justin808
committed
Make webpack CSS configuration resilient to missing dependencies

justin808
and
claude
committed
Add fallback CSS handling for tests without CSS loaders

justin808
and
claude
committed
Fix CSS modules fallback with identity proxy loader

justin808
and
claude
committed
Fix CSS modules webpack loader syntax error

justin808
and
claude
committed
Fix CSS modules export compatibility for ES6 imports

justin808
and
claude
committed
Revert webpack CSS modules configuration changes

justin808
and
claude
committed
Fix CSS dependency installation timing in generator

justin808
and
claude
committed
Add debug output to install_js_dependencies method
justin808
committed
Add comprehensive debug output to understand generator method execution
justin808
committed
Fix generator method visibility - move add_js_dependencies before private

justin808
and
claude
committed
Clean up generator code - remove debug output

justin808
and
claude
committed
Fix webpack config backup bug - copy actual file instead of template

justin808
and
claude
committed
Update spec/dummy/spec/support/selenium_logger.rb

justin808
and
alexeyr-ci2
committed
Security fixes and generator improvements

justin808
and
claude
committed
Fix CI linting and syntax errors

justin808
and
claude
committed
Fix shakapacker.yml template to include standard defaults

justin808
and
claude
committed
Fix bin/dev duplication and API issues

justin808
and
claude
committed
Improve Shakapacker auto-installation with better messaging and options

justin808
and
claude
committed
Update generator tests for new Shakapacker installation implementation

justin808
and
claude
committed
Fix package.json loading crash in generators

justin808
and
claude
committed
Fix bin/dev test to match updated API

justin808
and
claude
committed
Fix all RuboCop violations in generators

justin808
and
claude
committed
Improve post-install message with all requested enhancements

justin808
and
claude
committed
Change Redux description from 'Advanced Usage' to 'Optional'

justin808
and
claude
committed
Fix Redux terminology: 'gems' → 'package'

justin808
and
claude
committed
Improve git uncommitted changes error message

justin808
and
claude
committed
Improve generator output and fix Shakapacker detection

justin808
and
claude
committed
Update generator description to focus on React frontend and SSR

justin808
and
claude
committed
Fix typos and grammar errors in shakapacker.yml template

justin808
and
claude
committed
Reorganize generator messages for better UX

justin808
and
claude
committed
Improve Shakapacker installation message clarity

justin808
and
claude
committed
Implement seamless Shakapacker integration for React on Rails v15+

justin808
and
claude
committed
Remove PropTypes and fix webpack CSS configuration

justin808
and
claude
committed
Enable HMR in shakapacker.yml template

justin808
and
claude
committed
Fix RuboCop violations in base_generator.rb

justin808
and
claude
committed
Fix React Refresh babel plugin configuration for HMR

justin808
and
claude
committed
Improve React Refresh error handling and documentation

justin808
and
claude
committed
Move React Refresh troubleshooting to bin/dev help command

justin808
and
claude
committed
Make bin/dev work with both HMR enabled and disabled

justin808
and
claude
committed
Fix React Refresh overlay configuration error

justin808
and
claude
committed
Update to modern JSX transform

justin808
and
claude
committed
Restrict React Refresh to HMR mode only

justin808
and
claude
committed
Fix HMR by always enabling React Refresh webpack plugin in development

justin808
and
claude
committed
Fix React Refresh to work only in HMR mode, eliminating static mode warnings

justin808
and
claude
committed
Fix RuboCop violations and add exclusions for generator complexity

justin808
and
claude
committed
Complete RuboCop exclusions for install generator complexity

justin808
and
claude
committed
Fix CI failures for Shakapacker 8+ compatibility

justin808
and
claude
committed
Fix CI failures: Update to Shakapacker 8.2.0 and improve test stubbing

justin808
and
claude
committed
Fix rake task loading in Rails engine

justin808
and
claude
committed
Fix test stubbing issues for CI compatibility

justin808
and
claude
committed
Fix Redux template to use CSS modules consistently

justin808
and
claude
committed
Fix remaining test failures for CI compatibility

justin808
and
claude
committed
Final test fixes for remaining CI failures

justin808
and
claude
committed
Fix examples to use Shakapacker 8.2+ compatibility

justin808
and
claude
committed
Fix ESLint errors in React component templates for React 19

justin808
and
claude
committed
Remove FileManager test (was new, not existing test failure)

justin808
and
claude
committed
Fix ProcessManager test stubbing for system calls

justin808
and
claude
committed
Fix ServerManager test stubbing for Open3.capture2

justin808
and
claude
committed
Use >= 8.2.0 instead of ~> 8.2.0 for shakapacker in examples

justin808
and
claude
committed
Fix Bundler conflict in install generator

justin808
and
claude
committed
Improve shakapacker detection with robust multi-strategy approach

justin808
and
claude
committed
Fix RuboCop violations in install generator and test files

justin808
and
claude
committed
Add package manager prerequisite check and improve error handling

justin808
and
claude
committed
Remove webpacker support and require Shakapacker 8.2+

justin808
and
claude
committed
Simplify and modernize CI matrix configuration

justin808
and
claude
committed
Update CHANGELOG.md with breaking changes for v15.1

justin808
and
claude
committed
Fix webpack config issues and RuboCop violations

justin808
and
claude
committed
Trigger CI

justin808
and
claude
committed
Merge branch 'master' into update-generator-for-v15
justin808
authored
Fix prettier formatting in CHANGELOG.md

justin808
and
claude
committed
Fix install generator to respect --ignore-warnings for Shakapacker setup

justin808
and
claude
committed
Add comprehensive error handling for JavaScript dependency installation

justin808
and
claude
committed
Fix RuboCop violations and refactor complex methods

justin808
and
claude
committed
Fix failing install generator tests for Node.js detection and message content

ihabadham
and
claude
committed
ci: fix ruby 3.4 compatibility failures
ihabadham
committed
ci: fix test string formatting
ihabadham
committed

Uh oh!

Fix failing install generator tests for v16#1784ihabadham wants to merge 137 commits intomastershakacode/react_on_rails:masterfrom ihab-pr-1770-breaking-changes-for-v16shakacode/react_on_rails:ihab-pr-1770-breaking-changes-for-v16Copy head branch name to clipboard

Commits

Commits on Sep 16, 2025

Fix failing install generator tests for v16#1784
ihabadham wants to merge 137 commits intomasterfrom
ihab-pr-1770-breaking-changes-for-v16