-
-
Notifications
You must be signed in to change notification settings - Fork 638
Fix licensing vulnerabilities and strengthen freemium model legal protections #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6734c2a
a7c6aaf
39bd5bf
55c349a
a22230b
c98118b
f408946
ca4d093
37d1f26
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,14 +12,20 @@ All directories in the `react_on_rails` repository are MIT licensed: | |
| react_on_rails/ | ||
| βββ lib/react_on_rails/ # Core Ruby code (MIT) | ||
| βββ node_package/src/ # Core JS/TS code (MIT) | ||
| β βββ pro/ # Pro features placeholder (MIT but references pro) | ||
| β βββ pro/ # Pro features with license validation (Pro licensed) | ||
| βββ spec/ # Core tests (MIT) | ||
| βββ docs/ # Documentation (MIT) | ||
| βββ .github/ # GitHub workflows (MIT) | ||
| βββ [all other directories] # MIT | ||
| ``` | ||
|
|
||
| **Exception:** The `node_package/src/pro/` directory contains placeholder code that references Pro features, but the actual Pro implementation is in the separate `react_on_rails_pro` repository. | ||
| **Exception:** The `node_package/src/pro/` directory contains Pro implementation code licensed under the React on Rails Pro License. This code is included in the package but requires a valid Pro license to use. | ||
|
|
||
| **Important Distinction:** | ||
|
|
||
| - **MIT-licensed interface files** (outside `pro/` directories) can be freely modified under MIT terms | ||
| - **Using those modifications to access Pro features** without a license violates the Pro License | ||
| - **Pro-licensed files** (inside `pro/` directories) require a Pro license to use in any way | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "in any way." "Note, ShakaCode offers FREE licenses for educational and demonstration purposes." There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Claude finished @justin808's task ββ View job β’ β Task Completed
SummarySuccessfully added the note about free educational and demonstration licenses to
This clarification helps users understand that while Pro features require a license, ShakaCode offers free options for educational and demonstration use cases. Branch: |
||
|
|
||
| ### react_on_rails_pro Repository - Pro Licensed | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,7 +95,7 @@ react_on_rails/ (monorepo root) | |
|
|
||
| **A:** We maintain two separate repositories: | ||
|
|
||
| - **react_on_rails** (MIT) - Core functionality, completely free except pro directories as stated in LICENSE.md | ||
| - **react_on_rails** (MIT + Pro) - Core functionality is MIT-licensed and completely free. Pro features (in `pro/` directories) are Pro-licensed and require a subscription for production use | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing period. Add: Note, ShakaCode offers FREE licenses for educational and demonstration purposes. |
||
| - **react_on_rails_pro** (Pro License) - Advanced features, subscription required for production | ||
|
|
||
| ### Q: What requires a Pro subscription? | ||
|
|
@@ -110,6 +110,14 @@ react_on_rails/ (monorepo root) | |
|
|
||
| See [REACT-ON-RAILS-PRO-LICENSE.md](../REACT-ON-RAILS-PRO-LICENSE.md) for complete Pro license terms. | ||
|
|
||
| ### Q: Can I modify the MIT-licensed interface files? | ||
|
|
||
| **A:** Yes! Under the MIT license, you can freely modify any MIT-licensed files (those outside `pro/` directories). However: | ||
|
|
||
| - **Permitted:** Modifying MIT-licensed code for your own purposes | ||
| - **Not Permitted:** Using those modifications to access Pro features without a valid license | ||
| - **Distinction:** The MIT license grants you modification rights, but the Pro License restricts unauthorized use of Pro features | ||
|
|
||
| ### Q: Can I try Pro features for free? | ||
|
|
||
| **A:** Yes! Pro license allows free use for: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,7 +118,7 @@ | |
| "Rails" | ||
| ], | ||
| "author": "[email protected]", | ||
| "license": "MIT", | ||
| "license": "SEE LICENSE IN LICENSE.md", | ||
| "bugs": { | ||
| "url": "https://github.com/shakacode/react_on_rails/issues" | ||
| }, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.