Justin808/no use client server lint

.github/workflows/lint-js-and-ruby.yml

@@ -103,7 +103,7 @@ jobs:
         run: cd spec/dummy && RAILS_ENV="test" bundle exec rake react_on_rails:generate_packs
       - name: Detect dead code
         run: |
-          yarn run knip
+          yarn run knip --no-config-hints
           yarn run knip --production
       - name: Lint JS
         run: yarn run eslint --report-unused-disable-directives

.github/workflows/pro-integration-tests.yml

@@ -88,8 +88,15 @@ jobs:
           sudo yarn global add yalc
           yarn install --frozen-lockfile --no-progress --no-emoji
 
+      - name: Build and publish packages with yalc
+        run: |
+          cd ..
+          yarn run yalc:publish
+          cd react_on_rails_pro
+          yarn && yalc publish
+
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Install Ruby Gems for Pro dummy app
         run: |
@@ -204,8 +211,15 @@ jobs:
           sudo yarn global add yalc
           yarn install --frozen-lockfile --no-progress --no-emoji
 
+      - name: Build and publish packages with yalc
+        run: |
+          cd ..
+          yarn run yalc:publish
+          cd react_on_rails_pro
+          yarn && yalc publish
+
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Ensure minimum required Chrome version
         run: |
@@ -392,8 +406,15 @@ jobs:
           sudo yarn global add yalc
           yarn install --frozen-lockfile --no-progress --no-emoji
 
+      - name: Build and publish packages with yalc
+        run: |
+          cd ..
+          yarn run yalc:publish
+          cd react_on_rails_pro
+          yarn && yalc publish
+
       - name: Install Node modules with Yarn for Pro dummy app
-        run: cd spec/dummy && yarn install --frozen-lockfile --no-progress --no-emoji
+        run: cd spec/dummy && yarn install --ignore-scripts --no-progress --no-emoji
 
       - name: Ensure minimum required Chrome version
         run: |

Gemfile.development_dependencies

@@ -46,7 +46,7 @@ group :development, :test do
 end
 
 group :test do
-  gem "capybara"
+  gem "capybara", ">= 3.40"
   gem "capybara-screenshot"
   gem "coveralls", require: false
   gem "equivalent-xml"

Gemfile.lock

@@ -86,8 +86,8 @@ GEM
       minitest (>= 5.1)
       mutex_m
       tzinfo (~> 2.0)
-    addressable (2.8.6)
-      public_suffix (>= 2.0.2, < 6.0)
+    addressable (2.8.7)
+      public_suffix (>= 2.0.2, < 7.0)
     amazing_print (1.6.0)
     ast (2.4.2)
     base64 (0.2.0)
@@ -171,10 +171,10 @@ GEM
       net-pop
       net-smtp
     marcel (1.0.4)
-    matrix (0.4.2)
+    matrix (0.4.3)
     method_source (1.1.0)
     mini_mime (1.1.5)
-    mini_portile2 (2.8.7)
+    mini_portile2 (2.8.9)
     minitest (5.24.1)
     msgpack (1.7.2)
     mutex_m (0.2.0)
@@ -188,7 +188,7 @@ GEM
     net-smtp (0.5.0)
       net-protocol
     nio4r (2.7.3)
-    nokogiri (1.16.6)
+    nokogiri (1.18.10)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
     ostruct (0.6.1)
@@ -213,16 +213,16 @@ GEM
       pry (>= 0.12.0)
     psych (5.1.2)
       stringio
-    public_suffix (5.0.5)
+    public_suffix (6.0.2)
     puma (6.4.2)
       nio4r (~> 2.0)
-    racc (1.8.0)
-    rack (3.1.4)
+    racc (1.8.1)
+    rack (3.2.4)
     rack-proxy (0.7.7)
       rack
     rack-session (2.0.0)
       rack (>= 3.0.0)
-    rack-test (2.1.0)
+    rack-test (2.2.0)
       rack (>= 1.3)
     rackup (2.1.0)
       rack (>= 3)
@@ -263,7 +263,7 @@ GEM
       ffi (~> 1.0)
     rdoc (6.7.0)
       psych (>= 4.0.0)
-    regexp_parser (2.9.2)
+    regexp_parser (2.11.3)
     reline (0.5.9)
       io-console (~> 0.5)
     rexml (3.2.7)
@@ -407,7 +407,7 @@ DEPENDENCIES
   amazing_print
   benchmark
   bootsnap
-  capybara
+  capybara (>= 3.40)
   capybara-screenshot
   coveralls
   debug

TURBO_NAVIGATION_TEST_ISSUE.md

@@ -0,0 +1,188 @@
+# Issue: Add Playwright Test to Catch Turbo Navigation Regression
+
+## Summary
+
+A regression was discovered where JavaScript fails to work after navigating between pages using Turbo links (only works on hard refresh). This issue existed in the codebase for over a year but wasn't caught by automated tests.
+
+## Background
+
+### What Happened
+
+**Bug introduced in:** PR #1620 (commit 56ee2bd9, ~1 year ago)
+
+- Added Turbo (Hotwire) support to replace Turbolinks
+- Updated client-bundle.js to import `@hotwired/turbo-rails`
+- Set `turbo: true` in ReactOnRails options
+- **Forgot to update layout file** from `data-turbolinks-track` to `data-turbo-track`
+
+**Bug fixed in:** PR #1896 (commit f03b935d)
+
+- Updated `spec/dummy/app/views/layouts/application.html.erb`
+- Changed `data-turbolinks-track: true` to `data-turbo-track: 'reload'`
+- Re-added `defer: true` for proper Turbo compatibility
+
+### Impact
+
+Users experienced broken JavaScript when:
+
+1. Landing on a page (hard refresh) → ✅ JavaScript works
+2. Clicking a link to navigate → ❌ JavaScript breaks
+3. Hard refreshing again → ✅ JavaScript works again
+
+This severely degraded the user experience with Turbo navigation.
+
+## The Test Gap
+
+This bug went undetected for over a year, indicating a gap in test coverage for:
+
+- Turbo navigation flows
+- JavaScript execution after client-side navigation
+- React component hydration after Turbo page loads
+
+## Proposed Solution: Playwright E2E Test
+
+Add a Playwright test that verifies:
+
+### Test Scenario
+
+```javascript
+test('React components work after Turbo navigation', async ({ page }) => {
+  // 1. Hard refresh - load first page
+  await page.goto('/react_router');
+
+  // 2. Verify JavaScript works on initial load
+  await expect(page.locator('input#name')).toBeVisible();
+  await page.fill('input#name', 'Initial Page');
+  await expect(page.locator('h3')).toContainText('Initial Page');
+
+  // 3. Click a Turbo link to navigate to second page
+  await page.click('a[href="/react_router/second_page"]');
+  await page.waitForURL('/react_router/second_page');
+
+  // 4. Verify JavaScript STILL works after Turbo navigation
+  await expect(page.locator('input#name')).toBeVisible();
+  await page.fill('input#name', 'After Turbo Navigation');
+  await expect(page.locator('h3')).toContainText('After Turbo Navigation');
+
+  // 5. Navigate back
+  await page.click('a[href="/react_router"]');
+  await page.waitForURL('/react_router');
+
+  // 6. Verify JavaScript works after navigating back
+  await expect(page.locator('input#name')).toBeVisible();
+  await page.fill('input#name', 'After Back Navigation');
+  await expect(page.locator('h3')).toContainText('After Back Navigation');
+});
+```
+
+### What This Test Catches
+
+✅ JavaScript execution after Turbo navigation
+✅ React component hydration on client-side page loads
+✅ Proper data attributes for Turbo compatibility
+✅ Component lifecycle management with Turbo
+
+## Verification Steps
+
+To verify the Playwright test works correctly:
+
+### Step 1: Ensure Test Passes with Fix
+
+```bash
+# Current state (with fix) - test should PASS
+npm run test:e2e -- --grep "Turbo navigation"
+```
+
+### Step 2: Revert the Fix
+
+```bash
+# Revert to broken state
+git show f03b935d:spec/dummy/app/views/layouts/application.html.erb > spec/dummy/app/views/layouts/application.html.erb
+
+# Change line 13 back to:
+# <%= javascript_pack_tag('client-bundle', 'data-turbolinks-track': true) %>
+```
+
+### Step 3: Verify Test Fails
+
+```bash
+# With reverted fix - test should FAIL
+npm run test:e2e -- --grep "Turbo navigation"
+
+# Expected failure:
+# Error: Timeout waiting for element 'input#name' after Turbo navigation
+```
+
+### Step 4: Restore the Fix
+
+```bash
+# Restore the fix
+git checkout HEAD spec/dummy/app/views/layouts/application.html.erb
+
+# Test should PASS again
+npm run test:e2e -- --grep "Turbo navigation"
+```
+
+## Implementation Checklist
+
+- [ ] Create Playwright test file: `spec/dummy/spec/playwright/turbo_navigation.spec.js`
+- [ ] Add test that verifies React components work after Turbo navigation
+- [ ] Verify test passes with current fix in place
+- [ ] Manually revert fix and confirm test fails (proves test is effective)
+- [ ] Restore fix and confirm test passes again
+- [ ] Add test to CI pipeline
+- [ ] Document in CONTRIBUTING.md that Turbo navigation must be tested
+
+## Additional Test Cases to Consider
+
+1. **Multiple navigations**: Navigate through 3-4 pages to ensure no memory leaks
+2. **Back/forward buttons**: Test browser back/forward with Turbo
+3. **Turbo Frames**: Test components inside turbo frames
+4. **Turbo Streams**: Test components updated via turbo streams (Pro feature)
+5. **Redux stores**: Verify store state persists/resets appropriately
+
+## Files to Create/Modify
+
+```tree
+spec/dummy/spec/playwright/
+  ├── turbo_navigation.spec.js          (new)
+  └── support/
+      └── turbo_helpers.js              (new - optional helper functions)
+
+.github/workflows/
+  └── playwright.yml                    (update to run new tests)
+
+docs/contributor-info/
+  └── testing-turbo-navigation.md       (new - documentation)
+```
+
+## Success Criteria
+
+- [ ] Playwright test exists and passes in CI
+- [ ] Test catches the regression when fix is reverted
+- [ ] Test is documented and maintainable
+- [ ] Test runs in <30 seconds
+- [ ] No false positives in CI
+
+## References
+
+- **Original Turbo PR**: #1620 (56ee2bd9)
+- **Fix commit**: f03b935d
+- **Turbo documentation**: docs/building-features/turbolinks.md
+- **Related issue**: This regression went undetected for 1+ year
+
+## Notes for Implementer
+
+- Use React on Rails Pro dummy app for testing (has more Turbo features)
+- Consider using Playwright's `page.route()` to simulate slow networks
+- Add `data-testid` attributes to components if needed for reliable selectors
+- Test both development and production webpack builds
+- Ensure test works with different Turbo Drive settings (`turbo: true/false`)
+
+---
+
+**Priority**: High - This prevents regressions in core Turbo functionality
+
+**Estimated effort**: 2-4 hours (including documentation and verification)
+
+**Labels**: testing, playwright, turbo, e2e, regression-prevention