Skip to content

Conversation

@justin808
Copy link
Member

@justin808 justin808 commented Nov 9, 2025

Summary

LinkedIn returns 999 status codes for automated link checkers, causing false positives in CI markdown link checking. This is well-documented LinkedIn anti-bot behavior.

Change

Added LinkedIn to the in

Impact

  • Fixes failing markdown-link-check CI workflow
  • Prevents future false positives from LinkedIn URLs in documentation

Related

This fixes the CI failure seen in docs/testimonials/hvmn.md and any other files with LinkedIn profile links.

🤖 Generated with Claude Code


This change is Reviewable

LinkedIn returns 999 status codes for automated link checkers,
causing false positives in CI. This is a well-known LinkedIn
anti-bot behavior and should be ignored.

This fixes the failing markdown-link-check workflow.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Warning

Rate limit exceeded

@justin808 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 88f1367 and f200bcb.

📒 Files selected for processing (1)
  • .github/markdown-link-check-config.json (1 hunks)
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin808/fix-linkedin-link-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@justin808 justin808 merged commit 0364781 into master Nov 9, 2025
23 of 24 checks passed
@justin808 justin808 deleted the justin808/fix-linkedin-link-check branch November 9, 2025 06:44
@claude
Copy link

claude bot commented Nov 9, 2025

Code Review

✅ Overall Assessment

This is a well-justified and correctly implemented fix for a known issue with LinkedIn's anti-bot behavior. The change is minimal, focused, and addresses a legitimate CI problem.


🎯 Code Quality & Best Practices

Strengths:

  • Minimal change: Only adds the necessary ignore pattern without modifying unrelated configuration
  • Correct JSON syntax: The addition maintains valid JSON structure with proper comma placement
  • Consistent with existing patterns: Follows the same pattern format as other ignored domains (Slack, npm, etc.)
  • Well-documented: PR description clearly explains the LinkedIn 999 status code issue

Pattern specificity:

  • ✅ Pattern ^https://www\.linkedin\.com is appropriately scoped
  • ✅ Properly escaped regex pattern (backslashes before dots)
  • ✅ Anchored with ^ to prevent false matches

🐛 Potential Issues

None identified. The change is straightforward and low-risk.

Consideration (optional):
You might want to also cover the non-www variant if any docs use it:

{
  "pattern": "^https://(www\.)?linkedin\.com"
}

However, checking your codebase with grep -r "linkedin.com" --include="*.md", all current LinkedIn links use the www. variant, so the current pattern is sufficient for the immediate need.


🚀 Performance Considerations

Positive impact:

  • ✅ Reduces CI execution time by skipping problematic LinkedIn links
  • ✅ Prevents unnecessary retry attempts (configured with 5 retries)
  • ✅ No runtime performance impact (build-time only)

🔒 Security Concerns

None. This change:

  • Only affects CI link checking behavior
  • Does not introduce any security vulnerabilities
  • Follows the principle of least privilege (only ignores LinkedIn, not other domains)

🧪 Test Coverage

Not applicable - This is a configuration change for CI tooling.

Verification recommendation:
After merge, verify CI passes on docs with LinkedIn links (e.g., docs/testimonials/hvmn.md, docs/testimonials/resortpass.md)


📋 Checklist per CLAUDE.md

  • ✅ No Ruby code changes → RuboCop not needed
  • ✅ No JavaScript/TypeScript changes → ESLint not needed
  • ✅ JSON configuration only → No linting required
  • ✅ File ends with newline (confirmed in diff)
  • ✅ No CHANGELOG.md entry needed (infrastructure/CI change, not user-facing)

💡 Recommendation

APPROVE and MERGE - This is a clean fix for a well-known issue. The change is correct, minimal, and follows best practices.


Reviewed by Claude Code 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants