Skip to content

Fix failing React Router streamed component test #2027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix failing React Router streamed component test #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions react_on_rails_pro/spec/dummy/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ PATH
specs:
react_on_rails_pro (16.2.0.beta.4)
addressable
async (>= 2.6)
connection_pool
execjs (~> 2.9)
httpx (~> 1.5)
Expand Down Expand Up @@ -107,6 +108,12 @@ GEM
public_suffix (>= 2.0.2, < 7.0)
amazing_print (1.6.0)
ast (2.4.2)
async (2.27.4)
console (~> 1.29)
fiber-annotation
io-event (~> 1.11)
metrics (~> 0.12)
traces (~> 0.15)
base64 (0.2.0)
benchmark (0.4.0)
bigdecimal (3.1.9)
Expand All @@ -131,6 +138,10 @@ GEM
coderay (1.1.3)
concurrent-ruby (1.3.5)
connection_pool (2.5.0)
console (1.33.0)
fiber-annotation
fiber-local (~> 1.1)
json
coveralls (0.8.23)
json (>= 1.8, < 3)
simplecov (~> 0.16.1)
Expand Down Expand Up @@ -165,6 +176,9 @@ GEM
ffi (1.17.0-x86_64-darwin)
ffi (1.17.0-x86_64-linux-gnu)
ffi (1.17.0-x86_64-linux-musl)
fiber-annotation (0.2.0)
fiber-local (1.1.0)
fiber-storage
fiber-storage (1.0.0)
generator_spec (0.10.0)
activesupport (>= 3.0.0)
Expand All @@ -184,6 +198,7 @@ GEM
i18n (1.14.7)
concurrent-ruby (~> 1.0)
io-console (0.8.0)
io-event (1.12.1)
irb (1.15.1)
pp (>= 0.6.0)
rdoc (>= 4.0.0)
Expand Down Expand Up @@ -216,6 +231,7 @@ GEM
marcel (1.0.4)
matrix (0.4.2)
method_source (1.1.0)
metrics (0.14.0)
mini_mime (1.1.5)
mini_portile2 (2.8.8)
minitest (5.25.4)
Expand Down Expand Up @@ -447,6 +463,7 @@ GEM
tins (1.33.0)
bigdecimal
sync
traces (0.18.1)
turbolinks (5.2.1)
turbolinks-source (~> 5.2)
turbolinks-source (5.2.0)
Expand Down
10 changes: 6 additions & 4 deletions react_on_rails_pro/spec/dummy/spec/system/integration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,11 @@ def change_text_expect_dom_selector(dom_selector, expect_no_change: false)
it_behaves_like "streamed component tests", "/server_router/streaming-server-component",
"#ServerComponentRouter-react-component-0"

# Skip the test that fails without JavaScript - being addressed in another PR
it "renders the page completely on server and displays content on client even without JavaScript", # rubocop:disable RSpec/NoExpectationExample
skip: "Being addressed in another PR" do
# This test is overridden to skip it
# Override: This test is not applicable for React Router because client-side routing
# requires JavaScript to navigate to nested routes like /server_router/streaming-server-component.
# The test is kept but skipped to document why it doesn't apply to this scenario.
it "renders the page completely on server and displays content on client even without JavaScript",
skip: "React Router requires JavaScript for client-side routing to nested routes" do
# This test is overridden to skip it with explanation
end
end
Loading