Fix duplicate messages in install generator and address code review issues

.github/workflows/lint-js-and-ruby.yml

@@ -134,6 +134,8 @@ jobs:
         run: yarn run eslint --report-unused-disable-directives
       - name: Check formatting
         run: yarn start format.listDifferent
+      - name: Lint SCSS with stylelint
+        run: yarn run lint:scss
       - name: Type-check TypeScript
         run: yarn run type-check
       - name: Pack for attw and publint

.stylelintrc.json

@@ -0,0 +1,46 @@
+{
+  "extends": "stylelint-config-standard-scss",
+  "rules": {
+    "color-named": null,
+    "color-hex-length": "long",
+    "selector-id-pattern": null,
+    "scss/at-rule-no-unknown": [
+      true,
+      {
+        "ignoreAtRules": [
+          "include",
+          "mixin",
+          "each",
+          "if",
+          "else",
+          "for",
+          "while",
+          "function",
+          "return",
+          "use",
+          "forward"
+        ]
+      }
+    ],
+    "selector-class-pattern": null,
+    "custom-property-pattern": null,
+    "keyframes-name-pattern": null,
+    "scss/percent-placeholder-pattern": null,
+    "scss/dollar-variable-pattern": null,
+    "scss/at-function-pattern": null,
+    "scss/at-mixin-pattern": null,
+    "import-notation": null,
+    "at-rule-empty-line-before": null,
+    "font-family-name-quotes": null,
+    "rule-empty-line-before": null,
+    "scss/dollar-variable-empty-line-before": null,
+    "function-url-quotes": null
+  },
+  "ignoreFiles": [
+    "spec/dummy/app/assets/stylesheets/application.css",
+    "**/*.js",
+    "**/*.jsx",
+    "**/*.ts",
+    "**/*.tsx"
+  ]
+}

Gemfile.development_dependencies

@@ -38,7 +38,6 @@ group :development, :test do
   gem "rubocop", "1.61.0", require: false
   gem "rubocop-performance", "~>1.20.0", require: false
   gem "rubocop-rspec", "~>2.26", require: false
-  gem "scss_lint", require: false
   gem "spring", "~> 4.0"
   gem "lefthook", require: false
   # Added for Ruby 3.5+ compatibility to silence warnings

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    react_on_rails (16.2.0.beta.4)
+    react_on_rails (16.2.0.beta.5)
       addressable
       connection_pool
       execjs (~> 2.5)
@@ -332,11 +332,6 @@ GEM
       rubocop (~> 1.40)
     ruby-progressbar (1.13.0)
     rubyzip (2.3.2)
-    sass (3.7.4)
-      sass-listen (~> 4.0.0)
-    sass-listen (4.0.0)
-      rb-fsevent (~> 0.9, >= 0.9.4)
-      rb-inotify (~> 0.9, >= 0.9.7)
     sass-rails (6.0.0)
       sassc-rails (~> 2.1, >= 2.1.1)
     sassc (2.4.0)
@@ -347,8 +342,6 @@ GEM
       sprockets (> 3.0)
       sprockets-rails
       tilt
-    scss_lint (0.60.0)
-      sass (~> 3.5, >= 3.5.5)
     sdoc (2.6.1)
       rdoc (>= 5.0)
     securerandom (0.4.1)
@@ -473,7 +466,6 @@ DEPENDENCIES
   rubocop-performance (~> 1.20.0)
   rubocop-rspec (~> 2.26)
   sass-rails (~> 6.0)
-  scss_lint
   sdoc
   selenium-webdriver (= 4.9.0)
   shakapacker (= 9.3.0)

knip.ts

@@ -126,6 +126,12 @@ const config: KnipConfig = {
         '**/app-react16/**/*',
         // Playwright support files and helpers - generated by cypress-on-rails gem
         'e2e/playwright/support/**',
+        // Components and files used dynamically by React on Rails (registered at runtime)
+        'client/app/actions/**',
+        'client/app/components/**',
+        'client/app/routes/**',
+        'client/app/startup/**',
+        'client/app/store/**',
       ],
       project: ['**/*.{js,cjs,mjs,jsx,ts,cts,mts,tsx}!', 'config/webpack/*.js'],
       paths: {
@@ -156,6 +162,18 @@ const config: KnipConfig = {
         'url-loader',
         // Transitive dependency of shakapacker but listed as direct dependency
         'webpack-merge',
+        // Dependencies not detected in production mode
+        '@babel/runtime',
+        'mini-css-extract-plugin',
+        'css-loader',
+        'sass',
+        'sass-loader',
+        // Dependencies used dynamically by React on Rails
+        'create-react-class',
+        'react-helmet',
+        '@types/react-helmet',
+        'react-redux',
+        'react-router-dom',
       ],
     },
   },