Skip to content

Apply PR 2039 changes: modernize generator config and workflow #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2025
Merged

Apply PR 2039 changes: modernize generator config and workflow #2040

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e033c
Apply PR 2039 changes: modernize generator config and workflow updates
justin808 Nov 17, 2025
5a193d7
Add documentation and CHANGELOG for generator modernization changes
justin808 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
yarn install --no-progress --no-emoji ${{ matrix.dependency-level == 'latest' && '--frozen-lockfile' || '' }}
sudo yarn global add yalc
- name: yalc publish for react-on-rails
run: yalc publish
run: yarn yalc publish
- name: Install Ruby Gems for package
run: |
bundle lock --add-platform 'x86_64-linux'
Expand Down
4 changes: 3 additions & 1 deletion lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ ReactOnRails.configure do |config|
# - Requires adding ReactOnRails::TestHelper to spec/rails_helper.rb
# - See: https://github.com/shakacode/react_on_rails/blob/master/docs/guides/testing-configuration.md
#
# config.build_test_command = "RAILS_ENV=test bin/shakapacker"
config.build_test_command = "RAILS_ENV=test bin/shakapacker"

config.auto_load_bundle = true
config.components_subdirectory = "ror_components"
################################################################################
# Advanced Configuration
################################################################################
Expand Down
7 changes: 6 additions & 1 deletion rakelib/shakapacker_examples.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,13 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength
sh_in_dir(example_type.dir, "echo \"gem 'shakapacker', '>= 8.2.0'\" >> #{example_type.gemfile}")
bundle_install_in(example_type.dir)
sh_in_dir(example_type.dir, "rake shakapacker:install")
sh_in_dir(example_type.dir, example_type.generator_shell_commands)
# TODO: Remove REACT_ON_RAILS_SKIP_VALIDATION after generators start using next release
generator_commands = example_type.generator_shell_commands.map do |cmd|
"REACT_ON_RAILS_SKIP_VALIDATION=true #{cmd}"
end
sh_in_dir(example_type.dir, generator_commands)
sh_in_dir(example_type.dir, "npm install")
sh_in_dir(example_type.dir, "bundle exec rake react_on_rails:generate_packs")
end
end

Expand Down
Loading