-
-
Notifications
You must be signed in to change notification settings - Fork 638
Phase 5: Add Pro Node Renderer Package to workspace #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
justin808
wants to merge
53
commits into
master
Choose a base branch
from
justin808/monorepo-completion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 48 commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
6ae74c2
Phase 5: Add Pro Node Renderer Package to workspace
justin808 b3b5319
Update documentation formatting for Phase 5 completion
justin808 830634f
Document Pro changelog rename in Phase 6
justin808 dd815d4
Fix node-renderer TypeScript ESM compatibility and add missing depend…
justin808 b44e3ac
Disable yarn cache for Node 22 in Pro CI to fix V8 crash
justin808 463d5ab
Disable yarn cache for Node 22 in all remaining CI workflows
justin808 002d074
Update react_on_rails_pro build paths after node-renderer extraction
justin808 7161a7e
Address code review feedback: workspace protocol and file organization
justin808 3c69a7c
Improve build scripts and Node version pinning per code review
justin808 df8be6c
Fix: Revert workspace protocol to version numbers for Yarn Classic
justin808 2232f6e
Add knip configuration for node-renderer package
justin808 82021be
Remove invalid exports from react_on_rails_pro/package.json
justin808 5e1d68f
Fix Jest configuration for monorepo node-renderer tests
justin808 83b21f2
Fix node-renderer package.json and knip configuration
justin808 009c7d7
Format: Apply Prettier to knip.ts entry points array
justin808 f831007
Restore original formatting for fixture files to preserve git history
github-actions[bot] 5811716
delete new node-renderer package.json
Judahmeek 34c0b48
move old RoR Pro to be node-renderer package.json to preserve history
Judahmeek fa6c436
update prepack script to support node-renderer
Judahmeek c681c10
remove uneccessary devDependencies
Judahmeek 192234e
move preinstall script
Judahmeek e7befce
don't use yalc in a yarn workspace
Judahmeek cd414c2
prep for running yarn type-check
Judahmeek f067a28
Fix TS errors
alexeyr b491cfc
Fix knip issues
alexeyr b342ffe
Fix paths in RORP Node Renderer package.json
alexeyr 9d8a18c
Fix additional Knip issues
alexeyr 26f52e1
Remove many unused Knip ignores
alexeyr 8b652f6
rebased on origin/justin808/monorepo-completion
Judahmeek bdadbba
move prettier exclusions for node-renderer
Judahmeek ac397ad
remove unused coverage config for jest
Judahmeek 559f063
resolve knip reports
Judahmeek 3db614c
move jest scripts to root
Judahmeek 9a29146
use file references instead of stale versions
Judahmeek 463ed53
any change to react-on-rails should trigger pro tests
Judahmeek df16d80
use npm script instead of nps script for ci
Judahmeek f094dea
misc changes
Judahmeek 8b3bcde
Fix: Update documentation paths and ESM imports
justin808 8fdb246
Add missing jest-junit dependency to node-renderer package
justin808 6d416c9
Fix jest-junit reporter error in CI (#ISSUE)
justin808 58cc674
Add jest-junit to knip ignoreDependencies
justin808 cab046e
Fix jest-junit reporter error in CI (#ISSUE)
justin808 bb0f90a
Fix ESLint errors for CI
justin808 7818afc
Fix knip unused dependencies and package reference issues
justin808 c50c51b
Resolve merge conflicts after rebasing on master
justin808 c124df6
Fix workspace dependencies and build scripts
justin808 555770d
Fix workspace dependencies for Yarn Classic compatibility
justin808 09f8c27
Fix buildConsoleReplay parameter order and add Pro package to build c…
justin808 c5ac229
Add import/export rule to ESLint ignores for Pro package
justin808 b9e887f
Document workspace dependency testing requirements
justin808 851d5ee
Fix check-typescript script to use workspace type-check scripts
justin808 787681f
Update tests, workflows, and documentation for parameter order fix
justin808 fc0efdc
Add CI change detection for node-renderer package
justin808 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,205 @@ | ||
| # React on Rails Monorepo Migration - Analysis Index | ||
|
|
||
| This directory contains comprehensive analysis of the React on Rails monorepo migration status and recommendations. | ||
|
|
||
| ## Documents Overview | ||
|
|
||
| ### 1. MONOREPO_MIGRATION_ANALYSIS.md (PRIMARY - 16 KB) | ||
|
|
||
| **Comprehensive technical analysis of the entire monorepo migration** | ||
|
|
||
| Contains 12 detailed sections: | ||
|
|
||
| - Executive summary with current phase status | ||
| - Directory structure analysis (current vs target) | ||
| - YALC publishing configuration review | ||
| - Build and package scripts examination | ||
| - Documentation status | ||
| - Migration TODOs and issues | ||
| - CI/CD configuration analysis | ||
| - What's working and what needs attention | ||
| - Critical dependencies and interactions | ||
| - Key files to monitor | ||
| - Detailed next steps recommendations | ||
| - Success criteria definition | ||
|
|
||
| **Use when**: You need complete technical details, planning next phases, or understanding dependencies | ||
|
|
||
| ### 2. MIGRATION_QUICK_REFERENCE.md (REFERENCE - 6.8 KB) | ||
|
|
||
| **Quick lookup guide with status dashboards and checklists** | ||
|
|
||
| Contains: | ||
|
|
||
| - Migration phase status overview | ||
| - Directory structure comparison table | ||
| - YALC workflow comparison | ||
| - Path reference guide (CRITICAL) | ||
| - Status tables for all components | ||
| - Testing checklists | ||
| - Common issues and solutions | ||
| - Key metrics | ||
| - Next actions breakdown | ||
|
|
||
| **Use when**: You need quick answers, status updates, or testing guidance | ||
|
|
||
| ### 3. CLAUDE_MD_UPDATES.md (SUPPORTING - 11 KB) | ||
|
|
||
| **Documentation of CLAUDE.md improvements for monorepo** | ||
|
|
||
| Details improvements to project guidelines including: | ||
|
|
||
| - Monorepo-specific development instructions | ||
| - Workspace management guidance | ||
| - Build and testing updates | ||
| - CI configuration notes | ||
|
|
||
| **Use when**: Learning about updated developer guidelines | ||
|
|
||
| ### 4. claude-md-improvements.md (SUPPORTING - 8 KB) | ||
|
|
||
| **Additional CLAUDE.md enhancement recommendations** | ||
|
|
||
| Suggested improvements for developer experience in monorepo context. | ||
|
|
||
| **Use when**: Reviewing documentation enhancement opportunities | ||
|
|
||
| ## Quick Navigation | ||
|
|
||
| ### I Need To... | ||
|
|
||
| **Understand the current state** | ||
| → Read: Executive Summary in MONOREPO_MIGRATION_ANALYSIS.md | ||
|
|
||
| **Plan Phase 3 or 4 work** | ||
| → Read: "Recommendations for Next Steps" in MONOREPO_MIGRATION_ANALYSIS.md | ||
|
|
||
| **Find path references to update** | ||
| → Read: "Build Scripts - Path Reference Guide" in MIGRATION_QUICK_REFERENCE.md | ||
|
|
||
| **Check what's working/broken** | ||
| → Read: "What's Working Well" and "Critical Issues" in MONOREPO_MIGRATION_ANALYSIS.md | ||
|
|
||
| **Run tests before committing** | ||
| → Read: "Testing Checklist Before Merging" in MIGRATION_QUICK_REFERENCE.md | ||
|
|
||
| **Fix a specific issue** | ||
| → Read: "Common Issues & Solutions" in MIGRATION_QUICK_REFERENCE.md | ||
|
|
||
| **Monitor file changes** | ||
| → Read: "Key Files to Monitor" in MONOREPO_MIGRATION_ANALYSIS.md | ||
|
|
||
| **Setup workspace development** | ||
| → Read: CLAUDE_MD_UPDATES.md and claude-md-improvements.md | ||
|
|
||
| ## Key Facts at a Glance | ||
|
|
||
| **Current Phase**: Phase 2 (Git Merger) - COMPLETE | ||
| **Next Phase**: Phase 3 (Pre-Monorepo Structure Preparation) | ||
| **Estimated Timeline**: 4-5 weeks total (across 7 phases) | ||
|
|
||
| **Directory Structures**: | ||
|
|
||
| - Master: `node_package/` (backward compatible) | ||
| - Target: `packages/` (workspace structure) | ||
|
|
||
| **Critical Risk**: Path validation for yalc publish | ||
|
|
||
| - Past incident: 7-week silent failure (Sept 2024) | ||
| - Prevention: Always test `yarn run yalc.publish` manually | ||
|
|
||
| **Packages in Migration**: | ||
|
|
||
| - 2 Ruby gems (core + pro) | ||
| - 3 NPM packages (core + pro + pro-node-renderer) | ||
|
|
||
| ## Document Features | ||
|
|
||
| ### Color Coding in Quick Reference | ||
|
|
||
| - ✅ Working/Complete items | ||
| - ❌ Items needing updates | ||
| - 🔄 In-progress items | ||
| - ⏳ Planned items | ||
| - ⚠️ Critical issues | ||
|
|
||
| ### Sections in Analysis | ||
|
|
||
| - 📋 Executive summaries | ||
| - 🏗️ Architecture details | ||
| - ⚙️ Configuration specifics | ||
| - 📊 Status and metrics | ||
| - 🔍 Issues and risks | ||
| - 📝 Recommendations | ||
| - ✓ Checklists and criteria | ||
|
|
||
| ## Related Documentation | ||
|
|
||
| Outside this analysis directory: | ||
|
|
||
| - **Main Migration Plan**: `/docs/MONOREPO_MERGER_PLAN.md` (authoritative source) | ||
| - **Path Management Guide**: `/managing-file-paths.md` (validation procedures) | ||
| - **Build Script Testing**: `/testing-build-scripts.md` (artifact verification) | ||
| - **CI Monitoring**: `/master-health-monitoring.md` (CI status checks) | ||
| - **Contributing Guide**: `/CONTRIBUTING.md` (developer instructions) | ||
|
|
||
| ## Workflow Tips | ||
|
|
||
| ### Before Starting Work | ||
|
|
||
| 1. Read MIGRATION_QUICK_REFERENCE.md phase status | ||
| 2. Check "What Needs Attention" section | ||
| 3. Review relevant next steps | ||
|
|
||
| ### During Development | ||
|
|
||
| 1. Keep MIGRATION_QUICK_REFERENCE.md open for reference | ||
| 2. Use path reference guide when modifying configs | ||
| 3. Follow testing checklists before committing | ||
|
|
||
| ### Before Committing | ||
|
|
||
| 1. Verify all paths in MIGRATION_QUICK_REFERENCE.md | ||
| 2. Run testing checklist | ||
| 3. Validate build artifacts | ||
|
|
||
| ### Before Merging PR | ||
|
|
||
| 1. Confirm all tests pass | ||
| 2. Manual verification of yalc publish | ||
| 3. Documentation updates aligned | ||
|
|
||
| ## Contact & Updates | ||
|
|
||
| These documents were generated on: 2025-11-19 | ||
|
|
||
| Updates to analysis: | ||
|
|
||
| - Document updates based on phase completion | ||
| - New issues/findings during implementation | ||
| - Success criteria validation | ||
|
|
||
| ## Future Phases | ||
|
|
||
| **Phase 3**: Pre-Monorepo Structure Preparation | ||
|
|
||
| - Validate surabaya-v1 state | ||
| - Update all paths | ||
| - Test workspace commands | ||
|
|
||
| **Phase 4**: Final Monorepo Restructuring | ||
|
|
||
| - Consolidate Pro package | ||
| - Merge CI systems | ||
| - Update publishing process | ||
|
|
||
| **Phases 5-7**: Unification, Polish, and Cleanup | ||
|
|
||
| - Full CI/CD consolidation | ||
| - Documentation updates | ||
| - Legacy structure removal | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| --- | ||
|
|
||
| Last Updated: 2025-11-19 | ||
| Status: Ready for Phase 3 Planning | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.