Skip to content

Conversation

@ihabadham
Copy link
Contributor

@ihabadham ihabadham commented Sep 19, 2025

Summary by CodeRabbit

  • Chores
    • Updated frontend build dependencies: shakapacker bumped to 8.4.0 and react_on_rails usage adjusted; runtime now requires react_on_rails v16 or newer.
  • Tests
    • Test markup updated to use the new hydration attribute name for consistent component hydration behavior.

@coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2025

Walkthrough

Dependencies adjusted: react_on_rails now referenced from a specific GitHub branch and runtime minimum raised to >=16.0.0; shakapacker bumped to 8.4.0; package/dev dependencies updated; a test fixture attribute changed from data-force-load="true" to data-immediate-hydration="true".

Changes

Cohort / File(s) Summary
Ruby dependency file
Gemfile.development_dependencies
Replace gem "react_on_rails", "15.0.0" with GitHub branch shakacode/react_on_rails, branch abanoubghadban/restrict-usage-of-pro-features-to-rorp-licence; bump gem "shakapacker" from 8.0.08.4.0.
Gemspec
react_on_rails_pro.gemspec
Raise runtime dependency: s.add_runtime_dependency "react_on_rails", ">= 15.0.0">= 16.0.0.
JS dependency files
package.json, spec/dummy/package.json
Update react-on-rails: devDependency bumped 15.0.0 → 16.0.0 (and spec/dummy points to the GitHub branch source); bump shakapacker 8.0.0 → 8.4.0 in spec/dummy.
Test fixture
spec/dummy/spec/helpers/react_on_rails_pro_helper_spec.rb
Change script tag hydration attribute in test markup: data-force-load="true"data-immediate-hydration="true".

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Test as Test Runner
  participant Helper as Test Helper (markup)
  participant Browser as Browser / JS runtime
  Note over Test,Helper: Test renders component script tag
  Test->>Helper: render script tag
  Helper-->>Test: <script ... data-immediate-hydration="true">
  Note over Test,Browser: Page loads and scripts execute
  Test->>Browser: load page
  alt data-immediate-hydration present
    Browser->>Browser: hydrate component immediately
  else no immediate flag
    Browser->>Browser: defer hydration
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I twitch my whiskers at the new branch trail,
Upgraded packer and a git-sourced sail.
Hydrate at once — a bright, quick hop,
Tests align and CI won't stop.
Carrots tucked, I take a nap 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 531bf64 and 79157d5.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json (1 hunks)

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants