Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 21, 2025

This PR resolves several Maven build configuration issues that were causing warnings during compilation and potentially affecting build stability.

Issues Fixed

1. Duplicate Dependencies

  • org.json:json dependency: Removed duplicate declaration in shared/pom.xml (lines 161-165 and 179-183 both declared version 20231013)
  • httpclient dependency: Removed conflicting version in cli/pom.xml (kept 4.5.14, removed 4.5.13)

2. Deprecated Version Declaration

  • openai-gpt3-java service: Changed from deprecated LATEST version to specific version 0.18.2 in shared/pom.xml

3. Development Artifact Cleanup

  • AssumptionsTest.java: Removed unnecessary test file that was a development artifact and not part of the production test suite

Before

Maven builds showed multiple warnings:

[WARNING] 'dependencies.dependency.version' for com.theokanning.openai-gpt3-java:service:jar is either LATEST or RELEASE (both of them are being deprecated)
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.json:json:jar -> duplicate declaration of version 20231013
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.apache.httpcomponents:httpclient:jar -> version 4.5.14 vs 4.5.13

After

Clean Maven builds with no dependency-related warnings. All existing tests continue to pass (314 tests in CLI module, 51 tests in shared module).

Impact

  • Improved build stability and consistency
  • Eliminated Maven warnings that could indicate future compatibility issues
  • Cleaner dependency management following Maven best practices
  • No functional changes to application behavior

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.jdeploy.com
    • Triggering command: java -jar /home/REDACTED/work/jdeploy/jdeploy/tests/../cli/target/jdeploy-cli-1.0-SNAPSHOT.jar clean package (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@shannah shannah closed this Sep 21, 2025
Copilot AI changed the title [WIP] Fix this issue Fix Maven build configuration issues and remove development artifacts Sep 21, 2025
Copilot AI requested a review from shannah September 21, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants