Feature/smappservice #395
Merged
Feature/smappservice #395
+711
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the native launcher to use SMAppService (macOS 13+) by embedding
LaunchAgent plist files at Contents/Library/LaunchAgents/<command>.plist
during the macOS bundle creation phase. When the plist is present the
launcher can register the service via SMAppService; when absent it falls
back to the existing launchctl approach.
The bundler generates plists only for service_controller commands whose
arguments are fully static (no $ or {{ placeholders). An explicit
"embedPlist" boolean in the command spec allows developers to force or
suppress generation regardless of the heuristic.
Pipeline: PackageService parses commands from package.json → AppInfo →
Bundler → AppDescription → MacBundler.maybeCreateLaunchAgentPlists().
…62497' into feature/smappservice
The embedded plist should only include --jdeploy:command=<name> since launchd runs the process directly. The --jdeploy:service start args are only needed for CLI manual service management via launchctl. Also passes commands through installer path via Main.java.
…50885' into feature/smappservice
After template expansion, update package.json with the repository URL and jdeploy.github settings (repository, releases_repository, releases_url) when a GitHub repository is configured. Previously these were lost because the template has "repository": "" hardcoded. Fixes shannah/jdeploy-desktop-gui#65
…76976' into feature/smappservice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.