Only sort repository specifications #566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect remote versions specification ordering from config
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the ordering of repository specifications so that only file specifications are sorted alphabetically while remote configuration specifications remain in their defined order.
- Removed the general alphabetical sorting on specifications by eliminating the sortSpecificationsByName mapping.
- Added an explicit alphabetical sort on file specifications.
- Introduced a new test to verify that remote configuration specifications retain their order.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/features/projects/data/GitHubProjectDataSource.ts | Removed repository-wide alphabetical sorting; added a specific sort on branch/file specifications |
| test/projects/GitHubProjectDataSource.test.ts | Updated test descriptions and added a test to ensure remote specification order is preserved |
simonbs
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect remote versions specification ordering from config
Description
Motivation and Context
Screenshots (if appropriate):
Types of changes