Skip to content

Conversation

@simonbs
Copy link
Contributor

@simonbs simonbs commented Apr 28, 2025

No description provided.

dependabot bot and others added 30 commits March 31, 2025 08:05
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.2.6 to 29.3.0.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v29.2.6...v29.3.0)

---
updated-dependencies:
- dependency-name: ts-jest
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…29.3.0

Bump ts-jest from 29.2.6 to 29.3.0
Bumps the octokit group with 1 update: [@octokit/webhooks](https://github.com/octokit/webhooks.js).


Updates `@octokit/webhooks` from 13.7.5 to 13.8.0
- [Release notes](https://github.com/octokit/webhooks.js/releases)
- [Commits](octokit/webhooks.js@v13.7.5...v13.8.0)

---
updated-dependencies:
- dependency-name: "@octokit/webhooks"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: octokit
...

Signed-off-by: dependabot[bot] <[email protected]>
…6f757f991b

Bump @octokit/webhooks from 13.7.5 to 13.8.0 in the octokit group
Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `@typescript-eslint/eslint-plugin` from 8.27.0 to 8.28.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.28.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.27.0 to 8.28.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.28.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
…pt-eslint-be1372252b

Bump the typescript-eslint group with 2 updates
Bumps the mui group with 2 updates: [@mui/icons-material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-icons-material) and [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material).


Updates `@mui/icons-material` from 6.4.8 to 7.0.1
- [Release notes](https://github.com/mui/material-ui/releases)
- [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/material-ui/commits/v7.0.1/packages/mui-icons-material)

Updates `@mui/material` from 6.4.8 to 7.0.1
- [Release notes](https://github.com/mui/material-ui/releases)
- [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/material-ui/commits/v7.0.1/packages/mui-material)

---
updated-dependencies:
- dependency-name: "@mui/icons-material"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: mui
- dependency-name: "@mui/material"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: mui
...

Signed-off-by: dependabot[bot] <[email protected]>
…2b6f67

Bump the mui group with 2 updates
Bumps [next](https://github.com/vercel/next.js) from 15.2.3 to 15.3.0.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v15.2.3...v15.3.0)

---
updated-dependencies:
- dependency-name: next
  dependency-version: 15.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the octokit group with 2 updates in the / directory: [@octokit/auth-app](https://github.com/octokit/auth-app.js) and [@octokit/core](https://github.com/octokit/core.js).


Updates `@octokit/auth-app` from 7.1.5 to 7.2.1
- [Release notes](https://github.com/octokit/auth-app.js/releases)
- [Commits](octokit/auth-app.js@v7.1.5...v7.2.1)

Updates `@octokit/core` from 6.1.4 to 6.1.5
- [Release notes](https://github.com/octokit/core.js/releases)
- [Commits](octokit/core.js@v6.1.4...v6.1.5)

---
updated-dependencies:
- dependency-name: "@octokit/auth-app"
  dependency-version: 7.2.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: octokit
- dependency-name: "@octokit/core"
  dependency-version: 6.1.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: octokit
...

Signed-off-by: dependabot[bot] <[email protected]>
…ee5d0d6eab

Bump the octokit group across 1 directory with 2 updates
Bumps [styled-components](https://github.com/styled-components/styled-components) from 6.1.15 to 6.1.17.
- [Release notes](https://github.com/styled-components/styled-components/releases)
- [Commits](https://github.com/styled-components/styled-components/compare/[email protected]@6.1.17)

---
updated-dependencies:
- dependency-name: styled-components
  dependency-version: 6.1.17
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…omponents-6.1.17

Bump styled-components from 6.1.15 to 6.1.17
Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `@typescript-eslint/eslint-plugin` from 8.28.0 to 8.29.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.29.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.28.0 to 8.29.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.29.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.29.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.29.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
…pt-eslint-5209d3593f

Bump the typescript-eslint group with 2 updates
Bumps [sharp](https://github.com/lovell/sharp) from 0.33.5 to 0.34.1.
- [Release notes](https://github.com/lovell/sharp/releases)
- [Commits](lovell/sharp@v0.33.5...v0.34.1)

---
updated-dependencies:
- dependency-name: sharp
  dependency-version: 0.34.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
The default specification is the one displayed when no specification has been selected via the URL or when the project is opened from the sidebar.
Bumps the mui group with 2 updates: [@mui/icons-material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-icons-material) and [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material).


Updates `@mui/icons-material` from 7.0.1 to 7.0.2
- [Release notes](https://github.com/mui/material-ui/releases)
- [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/material-ui/commits/v7.0.2/packages/mui-icons-material)

Updates `@mui/material` from 7.0.1 to 7.0.2
- [Release notes](https://github.com/mui/material-ui/releases)
- [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/material-ui/commits/v7.0.2/packages/mui-material)

---
updated-dependencies:
- dependency-name: "@mui/icons-material"
  dependency-version: 7.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: mui
- dependency-name: "@mui/material"
  dependency-version: 7.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: mui
...

Signed-off-by: dependabot[bot] <[email protected]>
…aa10fa

Bump the mui group with 2 updates
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) from 4.0.8 to 4.1.4.
- [Release notes](https://github.com/tailwindlabs/tailwindcss/releases)
- [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.1.4/packages/tailwindcss)

---
updated-dependencies:
- dependency-name: tailwindcss
  dependency-version: 4.1.4
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…css-4.1.4

Bump tailwindcss from 4.0.8 to 4.1.4
Bumps [swagger-ui-react](https://github.com/swagger-api/swagger-ui) and [@types/swagger-ui-react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/swagger-ui-react). These dependencies needed to be updated together.

Updates `swagger-ui-react` from 5.20.1 to 5.21.0
- [Release notes](https://github.com/swagger-api/swagger-ui/releases)
- [Changelog](https://github.com/swagger-api/swagger-ui/blob/master/.releaserc)
- [Commits](swagger-api/swagger-ui@v5.20.1...v5.21.0)

Updates `@types/swagger-ui-react` from 4.19.0 to 5.18.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/swagger-ui-react)

---
updated-dependencies:
- dependency-name: swagger-ui-react
  dependency-version: 5.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: "@types/swagger-ui-react"
  dependency-version: 5.18.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
The default specification is the one displayed when no specification has been selected via the URL or when the project is opened from the sidebar.
…22f3b005

Bump swagger-ui-react and @types/swagger-ui-react
Bumps the octokit group with 1 update: [@octokit/webhooks](https://github.com/octokit/webhooks.js).


Updates `@octokit/webhooks` from 13.8.0 to 13.8.2
- [Release notes](https://github.com/octokit/webhooks.js/releases)
- [Commits](octokit/webhooks.js@v13.8.0...v13.8.2)

---
updated-dependencies:
- dependency-name: "@octokit/webhooks"
  dependency-version: 13.8.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: octokit
...

Signed-off-by: dependabot[bot] <[email protected]>
simonbs and others added 21 commits April 28, 2025 10:26
…d42f468fc0

Bump @octokit/webhooks from 13.8.0 to 13.8.2 in the octokit group
Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser).


Updates `@typescript-eslint/eslint-plugin` from 8.30.1 to 8.31.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.31.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 8.30.1 to 8.31.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.31.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-version: 8.31.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.31.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: typescript-eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
…pt-eslint-b871ca1edc

Bump the typescript-eslint group with 2 updates
Allows specifying default specification via config
…abetically

Sort specifications alphabetically
Respect remote versions specification ordering from config
Dependabot updates dependencies monthly
Bumps [@auth/pg-adapter](https://github.com/nextauthjs/next-auth) from 1.7.4 to 1.9.0.
- [Release notes](https://github.com/nextauthjs/next-auth/releases)
- [Commits](https://github.com/nextauthjs/next-auth/compare/@auth/[email protected]...@auth/[email protected])

---
updated-dependencies:
- dependency-name: "@auth/pg-adapter"
  dependency-version: 1.9.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…adapter-1.9.0

Bump @auth/pg-adapter from 1.7.4 to 1.9.0
Bumps [eslint-config-next](https://github.com/vercel/next.js/tree/HEAD/packages/eslint-config-next) from 15.2.2 to 15.3.1.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](https://github.com/vercel/next.js/commits/v15.3.1/packages/eslint-config-next)

---
updated-dependencies:
- dependency-name: eslint-config-next
  dependency-version: 15.3.1
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…onfig-next-15.3.1

Bump eslint-config-next from 15.2.2 to 15.3.1
Bumps [pg](https://github.com/brianc/node-postgres/tree/HEAD/packages/pg) and [@types/pg](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/pg). These dependencies needed to be updated together.

Updates `pg` from 8.13.1 to 8.15.6
- [Changelog](https://github.com/brianc/node-postgres/blob/master/CHANGELOG.md)
- [Commits](https://github.com/brianc/node-postgres/commits/[email protected]/packages/pg)

Updates `@types/pg` from 8.11.11 to 8.11.14
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/pg)

---
updated-dependencies:
- dependency-name: pg
  dependency-version: 8.15.6
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: "@types/pg"
  dependency-version: 8.11.14
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copilot AI review requested due to automatic review settings April 28, 2025 11:58
@simonbs simonbs requested a review from ulrikandersen as a code owner April 28, 2025 11:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the handling of default specifications in the projects domain. It introduces a new getDefaultSpecification function, updates multiple modules to use it, and adds the isDefault flag and defaultSpecificationName to support default selection behavior.

  • Introduces getDefaultSpecification in Version.ts and updates its usage in getProjectSelectionFromPath.ts, ProjectNavigator.ts, and useProjectSelection.ts.
  • Updates OpenApiSpecification and IProjectConfig to include isDefault and defaultSpecificationName respectively.
  • Updates the GitHubProjectDataSource and its tests to support default specification assignment and ordering.

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/features/projects/domain/index.ts Exposes getDefaultSpecification from Version.ts
src/features/projects/domain/getProjectSelectionFromPath.ts Uses getDefaultSpecification to select a specification
src/features/projects/domain/Version.ts Adds getDefaultSpecification function
src/features/projects/domain/ProjectNavigator.ts Uses getDefaultSpecification for navigation
src/features/projects/domain/OpenApiSpecification.ts Adds isDefault field to the specification schema
src/features/projects/domain/IProjectConfig.ts Adds defaultSpecificationName to the project config schema
src/features/projects/data/useProjectSelection.ts Uses getDefaultSpecification instead of direct indexing
src/features/projects/data/GitHubProjectDataSource.ts Updates version handling to set default specifications and sorts specifications
test/projects/GitHubProjectDataSource.test.ts Tests updated to verify correct default specification assignment and sort order
.github/dependabot.yml Changes dependabot update interval from weekly to monthly
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

test/projects/GitHubProjectDataSource.test.ts:210

  • There appears to be a duplicate entry for 'foo-service.yml' in this test case. Confirm if duplicate specifications are expected or if this is an oversight.
{ id: "foo-service.yml",

Comment on lines +254 to +260
return {
...version,
specifications: version.specifications.map(spec => ({
...spec,
isDefault: spec.name === defaultSpecificationName
}))
}
Copy link

Copilot AI Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function 'sortSpecificationsByName' is defined but never used. Consider removing it or integrating it into the version processing pipeline if sorting by specification name is intended.

Suggested change
return {
...version,
specifications: version.specifications.map(spec => ({
...spec,
isDefault: spec.name === defaultSpecificationName
}))
}
const updatedVersion = {
...version,
specifications: version.specifications.map(spec => ({
...spec,
isDefault: spec.name === defaultSpecificationName
}))
};
return this.sortSpecificationsByName(updatedVersion);

Copilot uses AI. Check for mistakes.
dependabot bot and others added 5 commits April 28, 2025 12:00
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.3.0 to 29.3.2.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v29.3.0...v29.3.2)

---
updated-dependencies:
- dependency-name: ts-jest
  dependency-version: 29.3.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…29.3.2

Bump ts-jest from 29.3.0 to 29.3.2
Bumps [yaml](https://github.com/eemeli/yaml) from 2.7.0 to 2.7.1.
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.7.0...v2.7.1)

---
updated-dependencies:
- dependency-name: yaml
  dependency-version: 2.7.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@simonbs simonbs closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants