Skip to content

Conversation

@simonbs
Copy link
Contributor

@simonbs simonbs commented Apr 29, 2025

Description

This addresses the security warnings from CodeQL pointing out that our workflows do not explicitly set permissions.

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copilot AI review requested due to automatic review settings April 29, 2025 07:09
@simonbs simonbs requested a review from ulrikandersen as a code owner April 29, 2025 07:09
@simonbs simonbs enabled auto-merge April 29, 2025 07:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses security warnings by explicitly setting permissions for GitHub Actions workflows.

  • Introduces explicit permission definitions (typically "contents: read") in multiple workflow files.
  • Adds additional permissions ("pull-requests: read" and "issues: write") for the check-changes-to-env workflow.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/test-sql-queries.yml Added explicit permissions: contents: read
.github/workflows/run-unit-tests.yml Added explicit permissions: contents: read
.github/workflows/lint.yml Added explicit permissions: contents: read
.github/workflows/check-changes-to-env.yml Added explicit permissions: contents: read, pull-requests: read, issues: write
.github/workflows/build.yml Added explicit permissions: contents: read
.github/workflows/build-docker-image.yml Added explicit permissions: contents: read

Copy link
Contributor

@ulrikandersen ulrikandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦺

@simonbs simonbs merged commit 0088f64 into develop Jun 3, 2025
8 checks passed
@simonbs simonbs deleted the enhancement/permissions-on-actions branch June 3, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants