Replaces swagger-ui-react with unpkg #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the swagger-ui-react dependency with a direct reference to Swagger UI via Unpkg, enabling an upgrade to React 19.1.0 and addressing a minor security warning.
- Removed swagger-ui-react and its associated styling
- Implemented fetching and YAML parsing of the API spec
- Dynamically loads Swagger UI scripts and styles from Unpkg
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/features/docs/view/Swagger.tsx:11
- Consider renaming the variable 'unkpgUrl' to 'unpkgUrl' for clarity and consistency with the Unpkg service name.
const unkpgUrl = "https://unpkg.com/[email protected]"
# Conflicts: # package-lock.json # package.json
Merged
ulrikandersen
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes swagger-ui-react and depends on Swagger UI using Unpkg instead, similar to what we do with Stoplight.
Description
This removes the dependency on the swagger-ui-react package, enabling us to update to React 19.1.0 and resolve a (minor) security warning.
Motivation and Context
Screenshots (if appropriate):
Types of changes